Skip to content

fix: add empty check when no manifests are returned #26053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitishfy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add empty check when no manifests are returned #26053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/argocd/commands/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3327,6 +3327,14 @@ func NewApplicationManifestsCommand(clientOpts *argocdclient.ClientOptions) *cob
log.Fatalf("Unknown source type '%s'", source)
}

// If no resources are found, there are two possible reasons
// either the application doesn't have manifests associated with it
// OR the redis cache is empty. Hence it is better to return early
if len(unstructureds) == 0 {
log.Infof("no Kubernetes resources found for application %q:"+
" manifests may not exist or the Redis cache is empty", appName)
return
}
for _, obj := range unstructureds {
fmt.Println("---")
yamlBytes, err := yaml.Marshal(obj)
Expand Down
Loading