Skip to content

Conversation

@ppapapetrou76
Copy link
Contributor

@ppapapetrou76 ppapapetrou76 commented Feb 11, 2026

1.26 was just released - fresh from the oven https://go.dev/doc/go1.26

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Feb 11, 2026

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@ppapapetrou76 ppapapetrou76 marked this pull request as ready for review February 11, 2026 09:41
@ppapapetrou76 ppapapetrou76 requested review from a team as code owners February 11, 2026 09:41
@ppapapetrou76 ppapapetrou76 marked this pull request as draft February 11, 2026 10:19
Signed-off-by: Patroklos Papapetrou <[email protected]>
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mixed opinions about this. We shouldn't be updating it right away since there can be some CVEs that may be associated with the new go version and yet to be public. Instead, we should wait.

Signed-off-by: Patroklos Papapetrou <[email protected]>
@ppapapetrou76 ppapapetrou76 marked this pull request as ready for review February 11, 2026 10:39
@ppapapetrou76 ppapapetrou76 requested a review from a team as a code owner February 11, 2026 10:39
@ppapapetrou76
Copy link
Contributor Author

ppapapetrou76 commented Feb 11, 2026

I've mixed opinions about this. We shouldn't be updating it right away since there can be some CVEs that may be associated with the new go version and yet to be public. Instead, we should wait.

This is what we did for 1.25.0 https://github.com/argoproj/argo-cd/pull/24148/changes and for 1.24 #22242

Besides CVEs are part of the game, even if we wait for 1.26.1 there might be new ones to be solved in 1.26.2 and this can go one for ever...

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I don't have any concerns regarding CVEs related to bumping to 0 patch version, we've also bumped to Go 0 patch version before.

Overall, LGTM.

An optional thing to consider:
The linter bump is addressed here: https://github.com/argoproj/argo-cd/pull/26382/files
Should we keep the linter related stuff separate from the Go version bump?

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree with your assessment @ppapapetrou76

@kencochrane
Copy link

As long as this doesn't get backported, I think it's fine since it will be a while until the Argo CD 3.4 release, plenty of time to let it soak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants