-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: bumps golang version to 1.26 in all places #26393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Patroklos Papapetrou <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mixed opinions about this. We shouldn't be updating it right away since there can be some CVEs that may be associated with the new go version and yet to be public. Instead, we should wait.
Signed-off-by: Patroklos Papapetrou <[email protected]>
This is what we did for 1.25.0 https://github.com/argoproj/argo-cd/pull/24148/changes and for 1.24 #22242 Besides CVEs are part of the game, even if we wait for 1.26.1 there might be new ones to be solved in 1.26.2 and this can go one for ever... |
reggie-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I don't have any concerns regarding CVEs related to bumping to 0 patch version, we've also bumped to Go 0 patch version before.
Overall, LGTM.
An optional thing to consider:
The linter bump is addressed here: https://github.com/argoproj/argo-cd/pull/26382/files
Should we keep the linter related stuff separate from the Go version bump?
blakepettersson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I agree with your assessment @ppapapetrou76
|
As long as this doesn't get backported, I think it's fine since it will be a while until the Argo CD 3.4 release, plenty of time to let it soak. |
1.26 was just released - fresh from the oven https://go.dev/doc/go1.26
Checklist: