fix: skip namespace check on cluster scoped rbac resources for auth reconcile #26403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #24833
The linked above issue describes that if a namespace is specified in the destination of an application's spec and that namespace does not exist, cluster scoped RBAC resources will fail to apply.
This is due to the auth reconcile operation that is performed doing a namespace check before hand due to a side effect where it creates namespaces that do not exist. This fix adds a check to see if the kind of the RBAC object is a ClusterRole or ClusterRoleBinding then skips the namespace check if it is.
Checklist: