-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(argo-workflows): Add Gateway API HTTPRoute support #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(argo-workflows): Add Gateway API HTTPRoute support #3567
Conversation
4e0165c to
8013792
Compare
Add support for Gateway API HTTPRoute and BackendTLSPolicy resources as an alternative to traditional Kubernetes Ingress for Argo Workflows server. Changes: - Add server-httproute.yaml template for Gateway API v1 HTTPRoute - Add server-backendtlspolicy.yaml template for v1alpha3 BackendTLSPolicy - Add httproute and backendTLSPolicy configuration sections to values.yaml - Add documentation for Gateway API usage in README.md.gotmpl - Bump chart version to 0.46.0 Key differences from Argo CD implementation: - No GRPCRoute support (Argo Workflows uses HTTP/HTTPS only, not gRPC) - Simplified port logic (single service port) All features are disabled by default for backward compatibility. Gateway API support is marked as EXPERIMENTAL. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
8013792 to
9fa1639
Compare
mkilchhofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good to me :)
| @@ -0,0 +1,26 @@ | |||
| {{- if and .Values.server.enabled .Values.server.backendTLSPolicy.enabled -}} | |||
| {{- $fullName := include "argo-workflows.server.fullname" . -}} | |||
| apiVersion: gateway.networking.k8s.io/v1alpha3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can directly go with v1 now
Xref on argo-cd chart:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Merge upstream/main and update Gateway API BackendTLSPolicy from v1alpha3 to stable v1, matching the argo-cd chart update. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
Summary
This PR adds Gateway API support to the Argo Workflows Helm chart, providing a modern alternative to traditional Ingress resources.
Added resources
Motivation
Gateway API is the successor to Ingress and is becoming the standard for traffic management in Kubernetes. This addition provides users with a modern, vendor-neutral way to expose Argo Workflows, aligning with the evolving Kubernetes ecosystem.
Key differences from Argo CD implementation
Testing
Notes
Experimental Status: Gateway API support is marked as EXPERIMENTAL. Support depends on your Gateway controller implementation. Some controllers may require additional configuration (e.g., BackendTLSPolicy for HTTPS backends). Not all Gateway controllers support BackendTLSPolicy (e.g., Cilium does not yet support it).
Checklist: