fix(argo-cd): support empty matches in GRPCRoute rules

[yurrriq]

templates/argocd-server/grpcroute.yaml

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• I have created a separate pull request for each chart according to pull requests
• My build is green (troubleshooting builds).

[yurrriq]

Despite the checklist item, it seems artifacthub.io/changes is not really used, so I didn't bother.

[yurrriq]

A workaround for now:

server:
  grpcroute:
    rules:
      - matches:
          - headers:
              - name: Content-Type
                type: RegularExpression
                value: "^application/grpc.*$"

[tico24]

Despite the checklist item, it seems artifacthub.io/changes is not really used, so I didn't bother.

It's used for every single PR and is a requirement.

[yurrriq]

It's used for every single PR and is a requirement.

Is this a new requirement then? There is only one entry so far...

[tico24]

Very much a requirement. Very much not new.

You replace the old with the new. That's how people know what has changed with your release.

[yurrriq]

Aha! I did not that new values replaced old ones. Thanks for the explanation.

[yurrriq]

Prior to this PR, the following values would result in invalid YAML.

# charts/argo-cd/ci/grpcroute-empty-matches.yaml
server:
  grpcroute:
    enabled: true
    rules:
      - matches: []

spec:
  rules:
      backendRefs:
        - name: argo-cd-argocd-server
          port: 443
          weight: 1

With this PR, the result is as follows, which is valid YAML.

spec:
  rules:
    - backendRefs:
        - name: argo-cd-argocd-server
          port: 443
          weight: 1

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.