fix(argo-rollouts): Remove deprecated preserveUnknownFields field from CRDs #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m CRDs The preserveUnknownFields field at the CRD spec level has been deprecated in Kubernetes and should be removed. The modern x-kubernetes-preserve-unknown-fields field is already present in the OpenAPI schema definitions where needed. This change removes the deprecated field from all 5 argo-rollouts CRDs: - rollout-crd.yaml - analysis-run-crd.yaml - analysis-template-crd.yaml - cluster-analysis-template-crd.yaml - experiment-crd.yaml
cmorinupgrade
requested review from
jmeridth,
tico24 and
yu-croco
as code owners
Collaborator
|
Thank you for your PR. Some people made the same PRs and we've been waiting for upstream to release it since we follow upstream's manifest. |
yu-croco
added
the
awaiting-upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
preserveUnknownFieldsfield from all argo-rollouts CRDs. This field has been deprecated in Kubernetes API and should be removed from CRD specifications.Details
The
preserveUnknownFieldsfield at the CRD spec level was deprecated in favor of the more granularx-kubernetes-preserve-unknown-fieldsfield within OpenAPI schemas. This change:preserveUnknownFields: falsefrom all 5 argo-rollouts CRDsx-kubernetes-preserve-unknown-fieldsfield is already correctly placed in the OpenAPI schema definitions where neededAffected CRDs
Testing
The CRDs maintain their existing validation behavior as
x-kubernetes-preserve-unknown-fieldsis already properly set in the schema definitions.Checklist