Skip to content

docs(argocd-image-updater): Edit values.authscript section to include a working example#3727

Merged
jmeridth merged 1 commit intoargoproj:mainfrom
Lyqed:main
Feb 15, 2026
Merged

docs(argocd-image-updater): Edit values.authscript section to include a working example#3727
jmeridth merged 1 commit intoargoproj:mainfrom
Lyqed:main

Conversation

@Lyqed
Copy link
Contributor

@Lyqed Lyqed commented Feb 13, 2026

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

What this PR does:
Fixes the authScripts.scripts example for Azure Workload Identity in values.yaml:

Fix shebang (#!/bin:sh → #!/bin/sh)
Run helm-docs

@Lyqed Lyqed marked this pull request as ready for review February 13, 2026 11:31
Copy link
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put this PR into draft because a) it is not ready and b) my inbox is on fire from your PR review requests.

@tico24 tico24 marked this pull request as draft February 13, 2026 11:38
@Lyqed Lyqed force-pushed the main branch 4 times, most recently from 10226a4 to 5688e22 Compare February 13, 2026 12:13
@Lyqed Lyqed marked this pull request as ready for review February 13, 2026 12:14
@yu-croco
Copy link
Collaborator

Could you pls refrain from keep creating and closing the same kind of PRs? Every PR gives maintainers a notification.

@therealnumber8
Copy link

Could you pls refrain from keep creating and closing the same kind of PRs? Every PR gives maintainers a notification.

TIL "draft mode" is a thing 😅

@yu-croco
Copy link
Collaborator

In addition to draft, you can just edit the one PR.

@github-actions github-actions bot added size/XS and removed size/M labels Feb 13, 2026
@Lyqed Lyqed force-pushed the main branch 2 times, most recently from 1a5a657 to bf6c2c8 Compare February 13, 2026 17:16
- kind: changed
description: Bump argocd-image-updater to v1.1.0
- kind: fixed
description: Bump argocd-image-updater to v1.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Bump argocd-image-updater to v1.1.1
description: Fix shebang line in azure-workload-identity example

Signed-off-by: Lyqed <98341862+Lyqed@users.noreply.github.com>
@jmeridth jmeridth requested a review from tico24 February 15, 2026 16:01
@jmeridth jmeridth merged commit 252c606 into argoproj:main Feb 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants