chore: enable perfsprint linter (#676)

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yaml

@@ -20,7 +20,7 @@ linters:
     - misspell
     # Disabled because of https://github.com/argoproj/argo-cd/issues/21705
     # - nolintlint
-#    - perfsprint
+    - perfsprint
     - revive
     - staticcheck
     - testifylint
@@ -45,6 +45,17 @@ linters-settings:
       - wrapperFunc #FIXME
   goimports:
     local-prefixes: github.com/argoproj/gitops-engine
+  perfsprint:
+    # Optimizes even if it requires an int or uint type cast.
+    int-conversion: true
+    # Optimizes into `err.Error()` even if it is only equivalent for non-nil errors.
+    err-error: true
+    # Optimizes `fmt.Errorf`.
+    errorf: true
+    # Optimizes `fmt.Sprintf` with only one argument.
+    sprintf1: true
+    # Optimizes into strings concatenation.
+    strconcat: true
   revive:
     # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md
     rules:

pkg/cache/cluster_test.go

@@ -2,6 +2,7 @@ package cache
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sort"
 	"strings"
@@ -625,7 +626,7 @@ metadata:
 					convertToVersionWasCalled = true
 
 					if testCaseCopy.localConvertFails {
-						return nil, fmt.Errorf("failed to convert resource client-side")
+						return nil, errors.New("failed to convert resource client-side")
 					}
 
 					return obj, nil

pkg/diff/diff.go

@@ -161,7 +161,7 @@ func ServerSideDiff(config, live *unstructured.Unstructured, opts ...Option) (*D
 func serverSideDiff(config, live *unstructured.Unstructured, opts ...Option) (*DiffResult, error) {
 	o := applyOptions(opts)
 	if o.serverSideDryRunner == nil {
-		return nil, fmt.Errorf("serverSideDryRunner is null")
+		return nil, errors.New("serverSideDryRunner is null")
 	}
 	predictedLiveStr, err := o.serverSideDryRunner.Run(context.Background(), config, o.manager)
 	if err != nil {

pkg/diff/diff_test.go

@@ -63,7 +63,7 @@ func printDiffInternal(name string, live *unstructured.Unstructured, target *uns
 	if err != nil {
 		return nil, err
 	}
-	liveFile := filepath.Join(tempDir, fmt.Sprintf("%s-live.yaml", name))
+	liveFile := filepath.Join(tempDir, name+"-live.yaml")
 	liveData := []byte("")
 	if live != nil {
 		liveData, err = yaml.Marshal(live)

pkg/sync/sync_context.go

@@ -299,7 +299,7 @@ const (
 // getOperationPhase returns a hook status from an _live_ unstructured object
 func (sc *syncContext) getOperationPhase(hook *unstructured.Unstructured) (common.OperationPhase, string, error) {
 	phase := common.OperationSucceeded
-	message := fmt.Sprintf("%s created", hook.GetName())
+	message := hook.GetName() + " created"
 
 	resHealth, err := health.GetResourceHealth(hook, sc.healthOverride)
 	if err != nil {

pkg/sync/sync_context_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"fmt"
 	"net/http"
 	"net/http/httptest"
 	"reflect"
@@ -107,7 +106,7 @@ func TestSyncValidate(t *testing.T) {
 
 func TestSyncNotPermittedNamespace(t *testing.T) {
 	syncCtx := newTestSyncCtx(nil, WithPermissionValidator(func(_ *unstructured.Unstructured, _ *v1.APIResource) error {
-		return fmt.Errorf("not permitted in project")
+		return errors.New("not permitted in project")
 	}))
 	targetPod := NewPod()
 	targetPod.SetNamespace("kube-system")
@@ -307,7 +306,7 @@ func TestSyncCreateFailure(t *testing.T) {
 		Commands: map[string]kubetest.KubectlOutput{
 			testSvc.GetName(): {
 				Output: "",
-				Err:    fmt.Errorf("foo"),
+				Err:    errors.New("foo"),
 			},
 		},
 	}
@@ -316,7 +315,7 @@ func TestSyncCreateFailure(t *testing.T) {
 		Commands: map[string]kubetest.KubectlOutput{
 			testSvc.GetName(): {
 				Output: "",
-				Err:    fmt.Errorf("foo"),
+				Err:    errors.New("foo"),
 			},
 		},
 	}
@@ -457,7 +456,7 @@ func TestSyncPruneFailure(t *testing.T) {
 		Commands: map[string]kubetest.KubectlOutput{
 			"test-service": {
 				Output: "",
-				Err:    fmt.Errorf("foo"),
+				Err:    errors.New("foo"),
 			},
 		},
 	}
@@ -466,7 +465,7 @@ func TestSyncPruneFailure(t *testing.T) {
 		Commands: map[string]kubetest.KubectlOutput{
 			"test-service": {
 				Output: "",
-				Err:    fmt.Errorf("foo"),
+				Err:    errors.New("foo"),
 			},
 		},
 	}
@@ -1195,11 +1194,11 @@ func TestSyncFailureHookWithFailedSync(t *testing.T) {
 	})
 	syncCtx.hooks = []*unstructured.Unstructured{newHook(synccommon.HookTypeSyncFail)}
 	mockKubectl := &kubetest.MockKubectlCmd{
-		Commands: map[string]kubetest.KubectlOutput{pod.GetName(): {Err: fmt.Errorf("")}},
+		Commands: map[string]kubetest.KubectlOutput{pod.GetName(): {Err: errors.New("")}},
 	}
 	syncCtx.kubectl = mockKubectl
 	mockResourceOps := kubetest.MockResourceOps{
-		Commands: map[string]kubetest.KubectlOutput{pod.GetName(): {Err: fmt.Errorf("")}},
+		Commands: map[string]kubetest.KubectlOutput{pod.GetName(): {Err: errors.New("")}},
 	}
 	syncCtx.resourceOps = &mockResourceOps
 
@@ -1248,18 +1247,18 @@ func TestRunSyncFailHooksFailed(t *testing.T) {
 	mockKubectl := &kubetest.MockKubectlCmd{
 		Commands: map[string]kubetest.KubectlOutput{
 			// Fail operation
-			pod.GetName(): {Err: fmt.Errorf("")},
+			pod.GetName(): {Err: errors.New("")},
 			// Fail a single SyncFail hook
-			failedSyncFailHook.GetName(): {Err: fmt.Errorf("")},
+			failedSyncFailHook.GetName(): {Err: errors.New("")},
 		},
 	}
 	syncCtx.kubectl = mockKubectl
 	mockResourceOps := kubetest.MockResourceOps{
 		Commands: map[string]kubetest.KubectlOutput{
 			// Fail operation
-			pod.GetName(): {Err: fmt.Errorf("")},
+			pod.GetName(): {Err: errors.New("")},
 			// Fail a single SyncFail hook
-			failedSyncFailHook.GetName(): {Err: fmt.Errorf("")},
+			failedSyncFailHook.GetName(): {Err: errors.New("")},
 		},
 	}
 	syncCtx.resourceOps = &mockResourceOps

pkg/utils/kube/kube.go

@@ -410,17 +410,17 @@ func GetDeploymentReplicas(u *unstructured.Unstructured) *int64 {
 // RetryUntilSucceed keep retrying given action with specified interval until action succeed or specified context is done.
 func RetryUntilSucceed(ctx context.Context, interval time.Duration, desc string, log logr.Logger, action func() error) {
 	pollErr := wait.PollUntilContextCancel(ctx, interval, true, func(_ context.Context) (bool /*done*/, error) {
-		log.V(1).Info(fmt.Sprintf("Start %s", desc))
+		log.V(1).Info("Start " + desc)
 		err := action()
 		if err == nil {
-			log.V(1).Info(fmt.Sprintf("Completed %s", desc))
+			log.V(1).Info("Completed " + desc)
 			return true, nil
 		}
 		log.V(1).Info(fmt.Sprintf("Failed to %s: %+v, retrying in %v", desc, err, interval))
 		return false, nil
 	})
 	if pollErr != nil {
 		// The only error that can happen here is wait.ErrWaitTimeout if ctx is done.
-		log.V(1).Info(fmt.Sprintf("Stop retrying %s", desc))
+		log.V(1).Info("Stop retrying " + desc)
 	}
 }