Skip to content

Conversation

@tommyk1m
Copy link
Contributor

@tommyk1m tommyk1m commented Jul 15, 2025

Fixes #342

The MessageGroupId was being processed in templating but not actually used when sending messages to SQS. This fix ensures that when a MessageGroupId is specified in the notification template, it's properly included in the SendMessageInput, which is required for FIFO queues.

  • Add MessageGroupId to SendMessageInput when available
  • Add unit tests to verify MessageGroupId inclusion/exclusion behavior
  • Fix ensures proper FIFO queue message grouping functionality

The MessageGroupId was being processed in templating but not actually
used when sending messages to SQS. This fix ensures that when a
MessageGroupId is specified in the notification template, it's properly
included in the SendMessageInput, which is required for FIFO queues.

- Add MessageGroupId to SendMessageInput when available
- Add unit tests to verify MessageGroupId inclusion/exclusion behavior
- Fix ensures proper FIFO queue message grouping functionality

Signed-off-by: Tommy Kim <[email protected]>
@tommyk1m tommyk1m marked this pull request as ready for review July 15, 2025 23:08
@danxmoran
Copy link
Contributor

@blakepettersson sorry for the spam - you seem to be the most recently-active maintainer in the project 😅

This fix would really help my team. Are you available to review it?

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.17%. Comparing base (da04400) to head (002e240).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   55.41%   60.17%   +4.75%     
==========================================
  Files          46       48       +2     
  Lines        4125     3656     -469     
==========================================
- Hits         2286     2200      -86     
+ Misses       1511     1106     -405     
- Partials      328      350      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pasha-codefresh pasha-codefresh merged commit f859d51 into argoproj:master Jan 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argo CD Notifications don't work properly with AWS SQS fifo queue

3 participants