Test: Fix processing of yul object files in equivalence checking #1021
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was already trying to handle yul files with named object format, however, the logic was not correct and we ended up trying to compile empty input, which resulted in error. There are several fixes: - `onlyAfter` now returns only lines *after* the matched line. Previously, the matched line was returned as well. - The regex used to check if we have `object` line in the file now no longer contains quotes. Previously, this regex never matched because of this quotes. - We now extract the object name in case of an object format. This is necessary to pass to the `yul` function. Previously, we always passed empty string. However, in case of named objects, the key in json is the object name.
blishko
force-pushed
the
fix-yul-with-objects
branch
from
495f617 to
0510795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was already trying to handle yul files with named object format, however, the logic was not correct and we ended up trying to compile empty input, which resulted in error.
There are several fixes:
onlyAfternow returns only lines after the matched line. Previously, the matched line was returned as well.objectline in the file now no longer contains quotes. Previously, this regex never matched because of this quotes.yulfunction. Previously, we always passed empty string. However, in case of named objects, the key in json is the object name.