Skip to content

Fix translating linkReferences #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Open

Fix translating linkReferences #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions linker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,22 @@ var findLinkReferences = function (bytecode) {
// trim trailing underscores
// NOTE: this has no way of knowing if the trailing underscore was part of the name
var libraryName = found[1].replace(/_+$/gm, '');
var fileName = libraryName;
var nameExtraction = /(.*):(.*)/.exec(libraryName);
if (nameExtraction) {
fileName = nameExtraction[1];
libraryName = nameExtraction[2];
}

if (!linkReferences[libraryName]) {
linkReferences[libraryName] = [];
if (!linkReferences[fileName]) {
linkReferences[fileName] = {};
}

linkReferences[libraryName].push({
linkReferences[fileName][libraryName] = {
// offsets are in bytes in binary representation (and not hex)
start: (offset + start) / 2,
length: 20
});
};

offset += start + 20;

Expand Down