Specialiser refactoring #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbenke
force-pushed
the
mbenke/respec
branch
2 times, most recently
from
7250f05 to
cf8be5d
Compare
Y-Nak
requested changes
Jan 7, 2026
src/Solcore/Backend/TVSubst.hs
Outdated
Member
There was a problem hiding this comment.
It seems this file is a dead file.
Collaborator
Author
There was a problem hiding this comment.
Indeed. I tried to make it a separate module but failed due to cyclic imports. Removed.
Comment on lines
379
to
383
| instance Semigroup TVRenaming where | ||
| r1 <> r2 = TVR (filter (uncurry (/=)) [ (u, renameTV r1 v) | (u, v) <- unTVR r2]) | ||
|
|
||
| instance Monoid TVRenaming where | ||
| mempty = TVR mempty |
Member
There was a problem hiding this comment.
It seems <> implementation doesn't satisfy the monoid law here. The right identity law is violated,
e.g., TVR [(a, b)] <> TVR [] should be equal to TVR [(a, b)], but actually returns TVR [].
Collaborator
Author
There was a problem hiding this comment.
Good catch! I have focused so much on removing redundant pairs, I forgot about this. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.