Update virtual modifier warning tests

matheusaaguiar · matheusaaguiar · commit e0aed72e2d02 · 2025-11-19T13:34:41.000-03:00
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_abstract.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_abstract.sol
@@ -5,3 +5,4 @@ abstract contract A {
 // ====
 // SMTEngine: all
 // ----
+// Warning 8429: (51-72): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_1.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_1.sol
@@ -20,5 +20,6 @@ contract B is A {
 // ====
 // SMTEngine: all
 // ----
-// Warning 6328: (209-223): CHC: Assertion violation happens here.
+// Warning 8429: (64-93): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 6328: (209-223): CHC: Assertion violation happens here.\nCounterexample:\ns = 42\nx = 42\n\nTransaction trace:\nB.constructor()\nState: s = 0\nB.set(42)\nState: s = 42\nA.f()
 // Info 1391: CHC: 1 verification condition(s) proved safe! Enable the model checker option "show proved safe" to see all of them.
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_2.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_2.sol
@@ -23,4 +23,6 @@ contract C is B {
 // ====
 // SMTEngine: all
 // ----
+// Warning 8429: (113-136): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (159-213): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // Warning 6328: (66-75): CHC: Assertion violation happens here.\nCounterexample:\ns = false\n\nTransaction trace:\nB.constructor()\nState: s = false\nA.f()
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_3.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_3.sol
@@ -18,5 +18,7 @@ contract B is A {
 // ====
 // SMTEngine: all
 // ----
-// Warning 6328: (94-104): CHC: Assertion violation happens here.
+// Warning 8429: (125-148): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (171-238): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 6328: (94-104): CHC: Assertion violation happens here.\nCounterexample:\ns = true\nx = true\n\nTransaction trace:\nB.constructor()\nState: s = false\nA.f()
 // Info 1391: CHC: 1 verification condition(s) proved safe! Enable the model checker option "show proved safe" to see all of them.
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_4.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_overriding_4.sol
@@ -36,6 +36,10 @@ contract D is B,C {
 // ====
 // SMTEngine: all
 // ----
+// Warning 8429: (262-294): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (317-367): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (390-440): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (465-520): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // Warning 6328: (160-174): CHC: Assertion violation happens here.\nCounterexample:\nx = 1\n\nTransaction trace:\nB.constructor()\nState: x = 0\nA.f()
 // Warning 6328: (193-207): CHC: Assertion violation happens here.\nCounterexample:\nx = 2\n\nTransaction trace:\nC.constructor()\nState: x = 0\nA.f()
 // Warning 6328: (226-240): CHC: Assertion violation happens here.\nCounterexample:\nx = 3\n\nTransaction trace:\nD.constructor()\nState: x = 0\nA.f()
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_virtual_static_call_1.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_virtual_static_call_1.sol
@@ -10,3 +10,4 @@ contract C is A {
 // ====
 // SMTEngine: all
 // ----
+// Warning 8429: (17-52): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/smtCheckerTests/modifiers/modifier_virtual_static_call_2.sol b/test/libsolidity/smtCheckerTests/modifiers/modifier_virtual_static_call_2.sol
@@ -20,5 +20,6 @@ contract C is A {
 // ====
 // SMTEngine: all
 // ----
-// Warning 6328: (83-98): CHC: Assertion violation happens here.
+// Warning 8429: (27-122): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 6328: (83-98): CHC: Assertion violation happens here.\nCounterexample:\nx = 0\n = 0\n\nTransaction trace:\nC.constructor()\nState: x = 0\nC.f()
 // Info 1391: CHC: 1 verification condition(s) proved safe! Enable the model checker option "show proved safe" to see all of them.
diff --git a/test/libsolidity/syntaxTests/controlFlow/modifiers/implemented_without_placeholder.sol b/test/libsolidity/syntaxTests/controlFlow/modifiers/implemented_without_placeholder.sol
@@ -6,3 +6,4 @@ abstract contract A {
 }
 // ----
 // SyntaxError 2883: (129-132): Modifier body does not contain '_'.
+// Warning 8429: (106-132): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/controlFlow/modifiers/modifier_different_functions.sol b/test/libsolidity/syntaxTests/controlFlow/modifiers/modifier_different_functions.sol
@@ -9,4 +9,5 @@ contract A {
 	}
 }
 // ----
+// Warning 8429: (140-172): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3464: (118-132): This variable is of storage pointer type and can be returned without prior assignment, which would lead to undefined behaviour.
diff --git a/test/libsolidity/syntaxTests/controlFlow/modifiers/modifier_override.sol b/test/libsolidity/syntaxTests/controlFlow/modifiers/modifier_override.sol
@@ -13,5 +13,6 @@ contract B is A {
 	}
 }
 // ----
+// Warning 8429: (71-115): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // Warning 5740: (65-69): Unreachable code.
 // TypeError 3464: (49-63): This variable is of storage pointer type and can be returned without prior assignment, which would lead to undefined behaviour.
diff --git a/test/libsolidity/syntaxTests/controlFlow/modifiers/non_implemented_modifier.sol b/test/libsolidity/syntaxTests/controlFlow/modifiers/non_implemented_modifier.sol
@@ -4,3 +4,5 @@ abstract contract A {
     }
     modifier mod() virtual;
 }
+// ----
+// Warning 8429: (106-129): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/immutable/inheritance_virtual_modifiers.sol b/test/libsolidity/syntaxTests/immutable/inheritance_virtual_modifiers.sol
@@ -17,3 +17,5 @@ contract C is B {
         _; f(x);
     }
 }
+// ----
+// Warning 8429: (88-137): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/inheritance/dataLocation/modifier_parameter_data_location_change_illegal_internal.sol b/test/libsolidity/syntaxTests/inheritance/dataLocation/modifier_parameter_data_location_change_illegal_internal.sol
@@ -10,4 +10,5 @@ contract B is A {
     }
 }
 // ----
+// Warning 8429: (26-66): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 1078: (153-214): Override changes modifier signature.
diff --git a/test/libsolidity/syntaxTests/inheritance/override/modifier_ambiguous.sol b/test/libsolidity/syntaxTests/inheritance/override/modifier_ambiguous.sol
@@ -8,3 +8,5 @@ contract C is A, B {
     modifier f() override(A,B) { _; }
 }
 // ----
+// Warning 8429: (17-44): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (64-91): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/inheritance/override/modifier_ambiguous_fail.sol b/test/libsolidity/syntaxTests/inheritance/override/modifier_ambiguous_fail.sol
@@ -7,4 +7,6 @@ contract B {
 contract C is A, B {
 }
 // ----
+// Warning 8429: (17-44): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (64-91): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 6480: (94-116): Derived contract must override modifier "f". Two or more base classes define modifier with same name.
diff --git a/test/libsolidity/syntaxTests/inheritance/override/modifier_inherited_different_signature.sol b/test/libsolidity/syntaxTests/inheritance/override/modifier_inherited_different_signature.sol
@@ -7,4 +7,6 @@ contract B {
 contract C is A, B {
 }
 // ----
+// Warning 8429: (17-50): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (70-97): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 6480: (100-122): Derived contract must override modifier "f". Two or more base classes define modifier with same name.
diff --git a/test/libsolidity/syntaxTests/inheritance/override/modifier_inherited_different_signature_override.sol b/test/libsolidity/syntaxTests/inheritance/override/modifier_inherited_different_signature_override.sol
@@ -8,4 +8,7 @@ contract C is A, B {
     modifier f() virtual override(A, B) { _; }
 }
 // ----
+// Warning 8429: (17-50): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (70-97): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (125-167): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 1078: (125-167): Override changes modifier signature.
diff --git a/test/libsolidity/syntaxTests/inheritance/override/nonintermediate_common_base_and_unique_implementation_modifier.sol b/test/libsolidity/syntaxTests/inheritance/override/nonintermediate_common_base_and_unique_implementation_modifier.sol
@@ -16,4 +16,7 @@ contract B is IJ
 }
 contract C is A, B {}
 // ----
+// Warning 8429: (14-41): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (58-85): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (111-154): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 6480: (229-250): Derived contract must override modifier "f". Two or more base classes define modifier with same name.
diff --git a/test/libsolidity/syntaxTests/inheritance/virtual/modifier_virtual_err.sol b/test/libsolidity/syntaxTests/inheritance/virtual/modifier_virtual_err.sol
@@ -4,4 +4,5 @@ library test {
     }
 }
 // ----
+// Warning 8429: (19-38): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3275: (19-38): Modifiers in a library cannot be virtual.
diff --git a/test/libsolidity/syntaxTests/inheritance/virtual/simple.sol b/test/libsolidity/syntaxTests/inheritance/virtual/simple.sol
@@ -5,3 +5,4 @@ contract C
 	modifier modi() virtual {_;}
 }
 // ----
+// Warning 8429: (83-111): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/definition_in_contract.sol b/test/libsolidity/syntaxTests/modifiers/definition_in_contract.sol
@@ -9,3 +9,6 @@ abstract contract A {
     modifier muv virtual;
 }
 // ----
+// Warning 8429: (39-65): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (117-143): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (148-169): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/definition_in_contract_unimplemented.sol b/test/libsolidity/syntaxTests/modifiers/definition_in_contract_unimplemented.sol
@@ -3,5 +3,6 @@ contract C {
     modifier muv virtual;
 }
 // ----
+// Warning 8429: (34-55): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3656: (0-57): Contract "C" should be marked as abstract.
 // TypeError 8063: (17-29): Modifiers without implementation must be marked virtual.
diff --git a/test/libsolidity/syntaxTests/modifiers/definition_in_interface.sol b/test/libsolidity/syntaxTests/modifiers/definition_in_interface.sol
@@ -5,6 +5,8 @@ interface I {
     modifier muv virtual;
 }
 // ----
+// Warning 8429: (57-83): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (88-109): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 6408: (18-35): Modifiers cannot be defined or declared in interfaces.
 // TypeError 6408: (40-52): Modifiers cannot be defined or declared in interfaces.
 // TypeError 8063: (40-52): Modifiers without implementation must be marked virtual.
diff --git a/test/libsolidity/syntaxTests/modifiers/definition_in_library.sol b/test/libsolidity/syntaxTests/modifiers/definition_in_library.sol
@@ -2,4 +2,5 @@ library L {
     modifier mv virtual { _; }
 }
 // ----
+// Warning 8429: (16-42): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3275: (16-42): Modifiers in a library cannot be virtual.
diff --git a/test/libsolidity/syntaxTests/modifiers/definition_in_library_unimplemented.sol b/test/libsolidity/syntaxTests/modifiers/definition_in_library_unimplemented.sol
@@ -3,5 +3,6 @@ library L {
     modifier muv virtual;
 }
 // ----
+// Warning 8429: (33-54): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 8063: (16-28): Modifiers without implementation must be marked virtual.
 // TypeError 3275: (33-54): Modifiers in a library cannot be virtual.
diff --git a/test/libsolidity/syntaxTests/modifiers/empty_modifier_body.sol b/test/libsolidity/syntaxTests/modifiers/empty_modifier_body.sol
@@ -13,3 +13,5 @@ contract D is C {
 	}
 }
 // ----
+// Warning 8429: (22-51): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (134-153): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/empty_modifier_err.sol b/test/libsolidity/syntaxTests/modifiers/empty_modifier_err.sol
@@ -5,6 +5,8 @@ contract C is B { }
 
 abstract contract D {modifier m;}
 // ----
+// Warning 8429: (12-31): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (55-74): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3656: (0-32): Contract "A" should be marked as abstract.
 // TypeError 3656: (76-95): Contract "C" should be marked as abstract.
 // TypeError 8063: (118-129): Modifiers without implementation must be marked virtual.
diff --git a/test/libsolidity/syntaxTests/modifiers/legal_modifier_override.sol b/test/libsolidity/syntaxTests/modifiers/legal_modifier_override.sol
@@ -1,3 +1,4 @@
 contract A { modifier mod(uint a) virtual { _; } }
 contract B is A { modifier mod(uint a) override { _; } }
 // ----
+// Warning 8429: (13-48): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/modifier_abstract_override.sol b/test/libsolidity/syntaxTests/modifiers/modifier_abstract_override.sol
@@ -8,4 +8,6 @@ contract C is B {
     function f() m public {}
 }
 // ----
+// Warning 8429: (17-44): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (78-108): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 4593: (78-108): Overriding an implemented modifier with an unimplemented modifier is not allowed.
diff --git a/test/libsolidity/syntaxTests/modifiers/multiple_inheritance_unimplemented_override.sol b/test/libsolidity/syntaxTests/modifiers/multiple_inheritance_unimplemented_override.sol
@@ -9,3 +9,5 @@ contract C is A, B {
     function f() m public {}
 }
 // ----
+// Warning 8429: (17-44): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (73-94): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/unimplemented_function_and_modifier.sol b/test/libsolidity/syntaxTests/modifiers/unimplemented_function_and_modifier.sol
@@ -26,6 +26,7 @@ contract E is A {
   modifier mod() override { _;}
 }
 // ----
+// Warning 8429: (110-133): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 3656: (137-254): Contract "B" should be marked as abstract.
 // TypeError 3656: (256-344): Contract "C" should be marked as abstract.
 // TypeError 3656: (346-466): Contract "D" should be marked as abstract.
diff --git a/test/libsolidity/syntaxTests/modifiers/unimplemented_override_unimplemented.sol b/test/libsolidity/syntaxTests/modifiers/unimplemented_override_unimplemented.sol
@@ -9,3 +9,6 @@ abstract contract C is B {
     function f() m public {}
 }
 // ----
+// Warning 8429: (26-47): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (81-111): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (145-175): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/use_unimplemented_from_base.sol b/test/libsolidity/syntaxTests/modifiers/use_unimplemented_from_base.sol
@@ -6,3 +6,5 @@ contract B is A {
     modifier m() virtual override { _; }
 }
 // ----
+// Warning 8429: (26-47): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (101-137): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/use_unimplemented_on_overridden_func.sol b/test/libsolidity/syntaxTests/modifiers/use_unimplemented_on_overridden_func.sol
@@ -6,3 +6,4 @@ abstract contract B is A {
     function f() public override {}
 }
 // ----
+// Warning 8429: (26-47): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
diff --git a/test/libsolidity/syntaxTests/modifiers/use_unimplemented_static.sol b/test/libsolidity/syntaxTests/modifiers/use_unimplemented_static.sol
@@ -9,4 +9,6 @@ contract C is A, B {
     function f() B.m public {}
 }
 // ----
+// Warning 8429: (17-44): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
+// Warning 8429: (73-94): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).
 // TypeError 1835: (174-177): Cannot call unimplemented modifier. The modifier has no implementation in the referenced contract. Refer to it by its unqualified name if you want to call the implementation from the most derived contract.

Original file line number	Diff line number	Diff line change
`@@ -6,3 +6,4 @@ abstract contract A {`
`6`	`6`	`}`
`7`	`7`	`// ----`
`8`	`8`	`// SyntaxError 2883: (129-132): Modifier body does not contain '_'.`
	`9`	`+// Warning 8429: (106-132): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).`
Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,5 @@ contract A {`
`9`	`9`	`}`
`10`	`10`	`}`
`11`	`11`	`// ----`
	`12`	`+// Warning 8429: (140-172): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).`
`12`	`13`	`// TypeError 3464: (118-132): This variable is of storage pointer type and can be returned without prior assignment, which would lead to undefined behaviour.`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@ contract B is A {`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`	`// ----`
	`16`	`+// Warning 8429: (71-115): Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9).`
`16`	`17`	`// Warning 5740: (65-69): Unreachable code.`
`17`	`18`	`// TypeError 3464: (49-63): This variable is of storage pointer type and can be returned without prior assignment, which would lead to undefined behaviour.`