Skip to content

Conversation

@cameel
Copy link
Collaborator

@cameel cameel commented Oct 10, 2025

Part of #16123.

This PR adds a separate checklist for optional pre-releases as a part of our new process for experimental features.

@cameel cameel self-assigned this Oct 10, 2025
Comment on lines +145 to +152
- [ ] Mention it on [Twitter](https://twitter.com/solidity_lang).
- [ ] Mention it on [Fosstodon](https://fosstodon.org/@solidity/).
- [ ] Mention it on [`#solidity` channel on Matrix](https://matrix.to/#/#ethereum_solidity:gitter.im).
- [ ] Mention it on [`#solc-tooling`](https://matrix.to/#/#solc-tooling:matrix.org).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a undecided about this bit. On one hand, we want prereleases to be super light, so comms should be optional. On the other hand not telling anyone defeats the point, so we should mention it somewhere.

I think what we want it to only advertise as much as needed to reach the people who we expect feedback from.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the typical delay between a prerelease and a full release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a week at the minimum. Not much point doing one when we have a full release just around the corner.

Hard to say what the maximum would be. They won't be regular so it can be anything.

Comment on lines +138 to +143
- [ ] Take the `github-binaries.tar` tarball from `c_release_binaries` run of the tagged commit on Circle CI and add all binaries from it to the release page.
Make sure it contains four binaries: `solc-windows.exe`, `solc-macos`, `solc-static-linux` and `soljson.js`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include the source tarball in a prerelease?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's. The github archives don't contain the submodule sources so otherwise we have an incomplete set of sources to build it as reference.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ok, though I'm not sure we'd ever really want to build it as a reference. The whole point of a prerelease are the binaries. We don't prepare a source archive for nightlies either.

@cameel cameel force-pushed the prerelease-checklist branch 3 times, most recently from a3390bc to a540037 Compare October 14, 2025 17:16
Comment on lines +145 to +152
- [ ] Mention it on [Twitter](https://twitter.com/solidity_lang).
- [ ] Mention it on [Fosstodon](https://fosstodon.org/@solidity/).
- [ ] Mention it on [`#solidity` channel on Matrix](https://matrix.to/#/#ethereum_solidity:gitter.im).
- [ ] Mention it on [`#solc-tooling`](https://matrix.to/#/#solc-tooling:matrix.org).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the typical delay between a prerelease and a full release?

- [ ] Bump vendored dependencies.
- [ ] Lean back, wait for bug reports and repeat from step 1 :).

## Prerelease
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section be moved up to be before ## Full release? Also, when creating a checklist prior to a (pre)release, is only the relevant section copied to hackmd/notes? E.g. if we're doing a full release, do we just copy the ## Full release section?

Copy link
Collaborator Author

@cameel cameel Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section be moved up to be before ## Full release?

I think it fits better at the end. The release is the main thing, requirements are based primarily on it, etc. The prerelease checklist is also more concise because the assumption is that you read the release checklist first - this would not work the other way around.

Also, when creating a checklist prior to a (pre)release, is only the relevant section copied to hackmd/notes? E.g. if we're doing a full release, do we just copy the ## Full release section?

Yeah, not much point including the requirements. They are something to be checked beforehand, not during the release.

- Click the `Publish release` button on the release page, creating the tag.
- [ ] Wait for the CI runs on the tag itself.
- [ ] Switch to the tag that archives have to be created for.
- [ ] Create the `prerelease.txt` file: `scripts/prerelease_suffix.sh pre "$(git describe --tags --exact-match)" > prerelease.txt`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this script is a part of #16246.

@cameel cameel force-pushed the prerelease-checklist branch from a540037 to b02d176 Compare October 15, 2025 17:30
@cameel cameel enabled auto-merge October 15, 2025 17:31
@cameel cameel merged commit f6a9245 into develop Oct 15, 2025
75 checks passed
@cameel cameel deleted the prerelease-checklist branch October 15, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants