Prerelease logic cleanup #16245
Merged
Prerelease logic cleanup #16245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
prerelease-logic-cleanup
branch
from
8dc6dea to
9bc0122
Compare
3 tasks
nikola-matic
approved these changes
Oct 13, 2025
clonker
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
I have checked scripts/create_source_tarball.sh as well as scripts/build.sh locally and it works. For the others we would have seen failure in CI. Looks good to me. I found the prerelease.txt handling confusing, especially in light of the "new" release vs prerelease vs nightly situation. But the PR is good to go in for all I am concerned with #16246 as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of refactors extracted from the upcoming PR that actually updates the logic.
The changes either have zero effect on behavior or only affect it in trivial ways, like giving the temporary dir a recognizable prefix or enabling Bash error handling.