Skip to content

Conversation

@r0qs
Copy link
Member

@r0qs r0qs commented Oct 13, 2025

Image builds for #16199

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404.clang-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:55c26efa5e74cff46f424396c21d5614531f8043c552e27d1c7277bc7d39db9b].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:978a3735643b310e2d18195c8e9b3e317fac995866eb6ed6d066fa8387dcd0e5].

@r0qs r0qs marked this pull request as ready for review October 13, 2025 17:27
@matheusaaguiar
Copy link
Contributor

Aren't we dropping ubuntu 22.04?

@cameel
Copy link
Collaborator

cameel commented Oct 14, 2025

We are: #16251.

@r0qs r0qs force-pushed the remove-duplicate-z3-binaries branch from 23ee759 to 6cd0062 Compare October 14, 2025 11:02
@r0qs
Copy link
Member Author

r0qs commented Oct 14, 2025

Aren't we dropping ubuntu 22.04?

Yes. I noticed that we forgot to remove the 22.04 files because of this PR ;)

Note, I skipped the last buildpackdeps builds because the images were already correctly built.

@r0qs r0qs force-pushed the remove-duplicate-z3-binaries branch from 6cd0062 to d8b4bd8 Compare October 14, 2025 12:31
@nikola-matic
Copy link
Contributor

Aren't we dropping ubuntu 22.04?

Yes. I noticed that we forgot to remove the 22.04 files because of this PR ;)

Note, I skipped the last buildpackdeps builds because the images were already correctly built.

Does it matter that they were correctly built previously (I see the hashes)? If you push, you should let the build run regardless - this way it looks like the CI job on the PR has failed.

@r0qs
Copy link
Member Author

r0qs commented Oct 15, 2025

Aren't we dropping ubuntu 22.04?

Yes. I noticed that we forgot to remove the 22.04 files because of this PR ;)
Note, I skipped the last buildpackdeps builds because the images were already correctly built.

Does it matter that they were correctly built previously (I see the hashes)? If you push, you should let the build run regardless - this way it looks like the CI job on the PR has failed.

I mean, if I push it will generate new hashes and yes, it doesn't matter as far as we are using the hashes that represent the latest correct change. Anyway, I triggered a re-run now.

@nikola-matic
Copy link
Contributor

Aren't we dropping ubuntu 22.04?

Yes. I noticed that we forgot to remove the 22.04 files because of this PR ;)
Note, I skipped the last buildpackdeps builds because the images were already correctly built.

Does it matter that they were correctly built previously (I see the hashes)? If you push, you should let the build run regardless - this way it looks like the CI job on the PR has failed.

I mean, if I push it will generate new hashes and yes, it doesn't matter as far as we are using the hashes that represent the latest correct change. Anyway, I triggered a re-run now.

Thanks for the rebuild <3

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:6eb911972a4335c21fd7725160374acf12158cc872c9215b46b335834c7dce63].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404.clang-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:485aab7c182f167a8d7ab2b06155c4cc77138c57c8d40261946d65ee74fd0f68].

@r0qs r0qs merged commit 359b014 into develop Oct 15, 2025
79 of 83 checks passed
@r0qs r0qs deleted the remove-duplicate-z3-binaries branch October 15, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants