Skip to content

Conversation

cameel
Copy link
Collaborator

@cameel cameel commented Oct 16, 2025

Follow-up to #16256.

During the prerelease we discovered that create_source_tarball.sh packages nlohmann-json docs as a part of our source. And it includes a bunch of unnecessary things, especially big images and rendered versions of the docs. For example:

Excluding doc/ and docs/ from these submodules shaves off almost half of the size of the source tarball (12.3 MB -> 7.3 MB).

These things are essentially dead weight as I would not expect anyone to look for them in our archive (they'd more likely go the source repo or to their docs webpage) and they do not the affect compiler build.

@cameel cameel self-assigned this Oct 16, 2025
@cameel cameel force-pushed the exclude-docs-from-source-tarball branch from 4042b32 to e69a192 Compare October 16, 2025 17:29
@cameel cameel force-pushed the exclude-docs-from-source-tarball branch from e69a192 to 8fd05e2 Compare October 20, 2025 11:16
@cameel cameel enabled auto-merge October 20, 2025 11:16
@cameel cameel disabled auto-merge October 20, 2025 11:18
@cameel
Copy link
Collaborator Author

cameel commented Oct 20, 2025

I was about to merge this, but decided to take one last look at c_source_tarball. For some reason it still produces a tarball that includes the docs, even though locally the docs were being excluded back when I created and tested the PR. Will have to investigate. For now reverting back to draft.

@cameel cameel marked this pull request as draft October 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants