Skip to content

Conversation

clonker
Copy link
Member

@clonker clonker commented Oct 20, 2025

  • replace std::variant for SSACFG::ValueId by tagged union
  • replace std::deque in SSACFGBuilder by a std::vector, possible by carefully reording operations in recursive variable definition chain
  • make ssacfg json serialization stateless (it was stateless already but wrapped in a class)

Makes the ssa cfg builder 26.5% faster.

@clonker clonker force-pushed the optimize_ssacfg_building branch 2 times, most recently from 22333a2 to 4256536 Compare October 20, 2025 13:09
@clonker clonker requested a review from r0qs October 20, 2025 13:09
@clonker clonker force-pushed the optimize_ssacfg_building branch 4 times, most recently from 3029083 to 8e80bbf Compare October 20, 2025 14:00
Copy link
Collaborator

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've just left a few small comments.

@clonker clonker force-pushed the optimize_ssacfg_building branch from 8e80bbf to d5d29bd Compare October 22, 2025 09:19
Copy link
Collaborator

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@clonker clonker merged commit e403242 into develop Oct 22, 2025
76 checks passed
@clonker clonker deleted the optimize_ssacfg_building branch October 22, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants