Fix assigning error or event selectors to constant variables. #16325
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
Gonna need a changelog entry. Also, rebasing should take care of the failing zeppelin job.
...ibsolidity/syntaxTests/types/functionTypes/selector/event_error_selector_pure_assignment.sol
Show resolved
Hide resolved
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
Approved by accident - just wanted to leave comments, hence the change request.
...ibsolidity/syntaxTests/types/functionTypes/selector/event_error_selector_pure_assignment.sol
Show resolved
Hide resolved
rodiazet
force-pushed
the
fix-error-event-selectors-constantness
branch
from
a87a0f7 to
84c3bc3
Compare
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
Looks good - just rephrase the changelog entry and also please squash the second "Address review comments." commit into the first one, and we can merge this.
Update Changelog.md Co-authored-by: Nikola Matić <[email protected]>
rodiazet
force-pushed
the
fix-error-event-selectors-constantness
branch
from
e0e3cc2 to
d843fe3
Compare
3 participants
This PR fixes assigning error or event selector value to a constant variable and adds a unit test covering this issue.
Closes: #13137