-
Notifications
You must be signed in to change notification settings - Fork 478
Handle vyper compiler warnings in asyncExec function #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9e143d3
handle vyper compiler warnings in asyncExec function
marcocastignoli 3628a4f
Handle Vyper compiler warnings for versions <0.4.0 and add tests for …
marcocastignoli e676d59
Fix test description
marcocastignoli 743fa79
Added test to check vyper warnings and errors for 0.3.10
marcocastignoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
import { expect } from 'chai'; | ||
import { useVyperCompiler } from '../src/lib/vyperCompiler'; | ||
import path from 'path'; | ||
|
||
describe('Verify Vyper Compiler', () => { | ||
const vyperRepoPath = path.join('/tmp', 'vyper-repo'); | ||
|
||
it('Should compile with vyper', async function () { | ||
const compiledJSON = await useVyperCompiler( | ||
vyperRepoPath, | ||
'0.3.7+commit.6020b8bb', | ||
{ | ||
language: 'Vyper', | ||
sources: { | ||
'test.vy': { | ||
content: '@external\ndef test() -> uint256:\n return 42', | ||
}, | ||
}, | ||
settings: { | ||
outputSelection: { | ||
'*': ['*'], | ||
}, | ||
}, | ||
}, | ||
); | ||
expect(compiledJSON?.contracts?.['test.vy']?.test).to.not.equal(undefined); | ||
}); | ||
|
||
it('Should handle vyper 0.3.10 warnings', async function () { | ||
const compiledJSON = await useVyperCompiler( | ||
vyperRepoPath, | ||
'0.3.10+commit.91361694', | ||
{ | ||
language: 'Vyper', | ||
sources: { | ||
'test.vy': { | ||
content: `@external | ||
@view | ||
def foo(x: uint256, y: int128) -> uint256: | ||
return shift(x, y)`, | ||
}, | ||
}, | ||
settings: { | ||
outputSelection: { | ||
'*': ['*'], | ||
}, | ||
}, | ||
}, | ||
); | ||
expect(compiledJSON?.contracts?.['test.vy']?.test).to.not.equal(undefined); | ||
// 0.3.10 doesn't include the warnings in the standardJson output | ||
expect(compiledJSON?.errors).to.be.undefined; | ||
}); | ||
|
||
it('Should handle vyper 0.3.10 warnings and errors', async function () { | ||
try { | ||
const compiledJSON = await useVyperCompiler( | ||
vyperRepoPath, | ||
'0.3.10+commit.91361694', | ||
{ | ||
language: 'Vyper', | ||
sources: { | ||
'test.vy': { | ||
content: `@exernal | ||
@view | ||
def foo(x: uint256, y: int128) -> uint256: | ||
return shift(x, y)`, | ||
}, | ||
}, | ||
settings: { | ||
outputSelection: { | ||
'*': ['*'], | ||
}, | ||
}, | ||
}, | ||
); | ||
expect(compiledJSON?.contracts?.['test.vy']?.test).to.not.equal( | ||
undefined, | ||
); | ||
} catch (error: any) { | ||
// 0.3.10 doesn't include the warnings in the standardJson output but in the errors | ||
expect(error.errors?.some((e: any) => e.severity === 'warning')).to.be | ||
.false; | ||
expect(error.errors?.some((e: any) => e.severity === 'error')).to.be.true; | ||
} | ||
}); | ||
|
||
it('Should handle vyper 0.4.0 warnings', async function () { | ||
const compiledJSON = await useVyperCompiler( | ||
vyperRepoPath, | ||
'0.4.0+commit.e9db8d9f', | ||
{ | ||
language: 'Vyper', | ||
sources: { | ||
'test.vy': { | ||
content: `@external | ||
@view | ||
def foo(x: uint256, y: int128) -> uint256: | ||
return shift(x, y)`, | ||
}, | ||
}, | ||
settings: { | ||
outputSelection: { | ||
'*': ['*'], | ||
}, | ||
}, | ||
}, | ||
); | ||
expect(compiledJSON?.contracts?.['test.vy']?.test).to.not.equal(undefined); | ||
// Should still compile successfully despite warnings | ||
expect(compiledJSON?.errors?.some((e) => e.severity === 'warning')).to.be | ||
.true; | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.