fix: token substitution in OPENCODE_CONFIG_CONTENT (redo)#174
Open
ariane-emory wants to merge 7 commits intodevfrom
Open
fix: token substitution in OPENCODE_CONFIG_CONTENT (redo)#174ariane-emory wants to merge 7 commits intodevfrom
ariane-emory wants to merge 7 commits intodevfrom
Conversation
Route OPENCODE_CONFIG_CONTENT through load() to enable {env:} and {file:}
token substitution. Uses the env var name as the path for clearer error
messages instead of a generic <inline> placeholder.
Fixes anomalyco#13219
Converts OPENCODE_CONFIG_CONTENT to a dynamic getter on the Flag object, matching the pattern used for OPENCODE_CONFIG_DIR and OPENCODE_CLIENT. This ensures env var changes are reflected at access time.
Ensure is present before calling load() to prevent Bun.write() from creating an unwanted OPENCODE_CONFIG_CONTENT file in the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NOTE: This PR injects the scheme value when necessary, so as to avoid the unintended creation of a
./OPENCODE_CONFIG_CONTENTfile in the project's root (as was the case in the prior merged PR on this issue, anomalyco#13384)Fixes anomalyco#13219
How did you verify your code works?
Manual testing,
bun typecheck,bun test.You may manually test by running commands akin to the following (assuming bash):