Merged
Conversation
- Move data processing logic () to . - Move service orchestration () to . - Clean up to focus solely on HTML generation. - Expose necessary private renderers as public functions to support the new architecture.
Update to patch in instead of , reflecting the recent refactor where the rendering logic was moved. This resolves test failures caused by unmocked translation calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Analysis Module: Separate Logic, Service, and Presentation Layers
Summary
This PR refactors the
analysismodule to strictly separate concerns, resolving circular dependencies and improving maintainability. It decomposes the monolithichtml_renderers.pyinto distinct layers for logic, service orchestration, and presentation.Key Changes
Architecture
stats_calculators.py): Moved heavy data processing logic (e.g.,generate_single_user_asymmetric_matrix_data) out of the view layer.report_service.py): Moved the orchestration logic (render_detailed_user_choices) here. This layer now handles data fetching, calculation, and stitching HTML components.html_renderers.py): Cleaned up to focus solely on generating HTML strings from pre-calculated data.Fixes & Improvements
test_report_service.pyto patchget_translationin the correct module path following the refactor.Commits
refactor(analysis): separate logic, service, and presentation layerstest(analysis): fix translation mock path in report service tests