Skip to content

Ionic 2.2.0 Support #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfaizanh wants to merge 11 commits into from
Closed

Ionic 2.2.0 Support #102

sfaizanh wants to merge 11 commits into from

Conversation

@sfaizanh
Copy link

@sfaizanh sfaizanh commented Mar 9, 2017

Update dependencies
Added Readme and License.md files
Fixed AOT issue in ionic-audio-web-track.ts

sfaizanh added 10 commits March 4, 2017 03:19
@sfaizanh
NPM fixes
bf67476
@sfaizanh
Merge remote-tracking branch 'arielfaur/2.0' into 2.0
d7673b2
@sfaizanh
Removed ignoring .ts files
683c3fa 
Demo Contains .ts files
@sfaizanh
Merge remote-tracking branch 'arielfaur/2.0' into 2.0
b524639
@sfaizanh
Merge remote-tracking branch 'arielfaur/2.0' into 2.0
ff3176d 
# Conflicts:
#	.npmignore
@sfaizanh
Updating package.json
9cbc21d 
Update new version (2.2.0) of Ionic.
Updated all the dependencies
@sfaizanh
Commenting AudioContext from ionic-audio-web-track.ts
b65a1b4 
AOT failed to build because it cannot find the reference of AudioContext

```
Failed on type
{"filePath":"/Users/faizanhasan/app/v2/node_modules/ionic-audio/dist/ion
ic-audio-web-track.ts","name":"WebAudioTrack","members":[]} with error
Error: Error encountered resolving symbol values statically. Could not
resolve type AudioContext (position 26:105 in the original .ts file),
resolving symbol WebAudioTrack in
/Users/faizanhasan/app/v2/node_modules/ionic-audio/dist/ionic-audio-web-
track.ts
build prod failed: Error encountered resolving symbol values
statically. Could not resolve type AudioContext
            (position 26:105 in the original .ts file), resolving
symbol WebAudioTrack in

/Users/faizanhasan/app/v2/node_modules/ionic-audio/dist/ionic-audio-web-
track.ts
ionic-app-script task: "build"
Error: Error encountered resolving symbol values statically. Could not
resolve type AudioContext (position
            26:105 in the original .ts file), resolving symbol
WebAudioTrack in

/Users/faizanhasan/app/v2/node_modules/ionic-audio/dist/ionic-audio-web-
track.ts
Error: Error encountered resolving symbol values statically. Could not
resolve type AudioContext (position 26:105 in the original .ts file),
resolving symbol WebAudioTrack in
/Users/faizanhasan/app/v2/node_modules/ionic-audio/dist/ionic-audio-web-
track.ts
```
@sfaizanh
Adding Readme and License file
ae40518
@sfaizanh
Adding Content to README.md and LICENSE.md
7079161
@sfaizanh
Updating Package.json
53625b9 
@arielfaur you have to change` "ionic-audio": "^2.3.4"` with the latest
version when you publish npm
@sfaizanh
Copy link
Author

sfaizanh commented Mar 13, 2017

@arielfaur any update?

@sfaizanh sfaizanh mentioned this pull request Mar 14, 2017
Closed
@arielfaur
Copy link
Owner

arielfaur commented Mar 22, 2017

Hi @sfaizanh I have merged your PR and am testing but I still get build errors with the -prod flag. Any ideas?

capture

@sfaizanh
Copy link
Author

sfaizanh commented Mar 22, 2017

Hi @arielfaur, i'm in middle of something i'll update you in an hour

@sfaizanh
Copy link
Author

sfaizanh commented Mar 24, 2017

Hi @arielfaur, It works fine "Build Success" may be you haven't change the ionic audio in demo/package.json

cd demo
"ionic-audio": "^2.3.4" to "ionic-audio": "git+https://github.com/sfaizanh/ionic-audio.git#2.0"
rm -r node_modules (remove node_modules)
npm i
cd node_modules/ionic-audio
npm run prepublish

then in project directory
ionic build ios --release --prod or ionic build android --release --prod

My apologies for the delay

@sfaizanh
Removed dependencies and Added into DevDependencies
81da41b 
Updated dependencies only for developers.
Added `npm run build`
@sfaizanh
Copy link
Author

sfaizanh commented Mar 24, 2017

@arielfaur i have removed dependencies and added to devDependencies so that users will not affects on ionic-version update 81da41b

@sfaizanh
Copy link
Author

sfaizanh commented Mar 24, 2017

@arielfaur if you are merging #101 pull request then merge it first then i'll update it so that this pull can be merged with no conflicts

@borodiliz
Copy link

borodiliz commented Mar 24, 2017 •
edited
Loading

Thanks @arielfaur . Works fine on ionic 2.3.0 and buiding with --prod ( AoT )

@codinronan
Copy link

codinronan commented Mar 29, 2017 •
edited
Loading

Thank you guys for this! Now that AoT build works my app startup time is like 2 seconds (down from 10!!). Amazing!

@arielfaur can we get this and #101 merged? I love this library

@sfaizanh
Copy link
Author

sfaizanh commented Mar 29, 2017 •
edited
Loading

I would say Merge #101 first then i have to update the code so that we don't have merge issue

@sfaizanh sfaizanh mentioned this pull request Mar 29, 2017
Closed
@sfaizanh
Copy link
Author

sfaizanh commented Apr 8, 2017

Hi @arielfaur Angular 4 showing some warnings.

Warning: Can't resolve all parameters for WebAudioTrack in 
/Users/faizanhasan/Documents/v2/node_modules/ionic-audio/dist/ionic-audio-web-track.ts: (?, ?). 
This will become an error in Angular v5.x

Warning: Can't resolve all parameters for CordovaAudioTrack in 
/Users/faizanhasan/Documents/v2/node_modules/ionic-audio/dist/ionic-audio-cordova-track.ts: (?).
This will become an error in Angular v5.x

@sfaizanh sfaizanh closed this Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfaizanh @arielfaur @borodiliz @codinronan