Add support for --fb option (like --graphics but without X)#388
Add support for --fb option (like --graphics but without X)#388intelfx wants to merge 4 commits intoarighi:mainfrom
--fb option (like --graphics but without X)#388Conversation
…ting X Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
No functional change. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
On single `--verbose`, only pass `loglevel=7` rather than `debug`. On `--verbose --verbose`, pass `debug` as previously. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
dff398d to
d593bc1
Compare
arighi
left a comment
There was a problem hiding this comment.
This looks interesting, do you have any special use case / example on how to use it? Also CI isn't happy, but should be an easy fix. Thanks!
| ) | ||
| g.add_argument( | ||
| "--verbose", | ||
| action="count", |
There was a problem hiding this comment.
Why we need to accept multiple --verbose?
| initrdpath = None | ||
|
|
||
| if args.verbose: | ||
| if args.verbose >= 2: |
There was a problem hiding this comment.
Oh I see, multiple --verbose enable debug. I think this should go in a separate PR.
I just made it for myself because I was trying to do something with fbcon. If you run
OK, I'll split off the |
Ack, another nice thing to do would be to enable the required CONFIG_* options in the default config to properly support --fb, see: virtme-ng/virtme/commands/configkernel.py Line 196 in 951e30a
I think it's fine to include this commit in the current PR. Thanks! |
matttbe
left a comment
There was a problem hiding this comment.
(Explicitly marking this PR as "Request Changes", because there are suggested changes.)
Add support for a
--fboption that starts QEMU in a graphical mode but without actually launching any graphical environment. This is intended for working with the framebuffer console (or anything else that might be run on top of such).Additionally, this makes a few changes that synergize with the one above:
--verboseonly enablesloglevel=7and--show-boot-console--verboseis now required to also enabledebug