feat(ci): Implement Automated Unit and End-to-End Testing Workflows

[google-labs-jules]

This change implements a new CI workflow that runs linting, building, unit tests, and E2E tests on all pushes to the leader branch and on all pull requests. The deployment workflow has been updated to only run after the successful completion of this new CI workflow. The pr-quality-standalone.yml workflow has also been refactored to remove the redundant test jobs.

Fixes #2927

---

PR created automatically by Jules for task 734690193281437905 started by @arii

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

---

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

[arii]

📋 Quality Gate Results

Check	Status
Knip	✅ success
Lint	✅ success
Build	✅ success
Infra Tests	✅ success
Unit Tests	✅ success
Perf Tests	✅ success
Visual Tests	✅ success

✅ All quality checks passed!

---

Report generated for commit: 93a8531a8a108a55c7aeccc21ce47cd0364ea5eb

[arii]

Reviewed commit: 93a8531a8a108a55c7aeccc21ce47cd0364ea5eb

This PR introduces a significant and positive refactoring of the CI/CD pipeline by consolidating core checks (lint, build, unit, visual tests) into a new ci.yml workflow. It improves the reliability of the deployment process by making it dependent on the successful completion of the ci.yml workflow via workflow_run events, rather than just push to leader. The removal of redundant test jobs from pr-quality-standalone.yml also streamlines the overall process.

Strengths

• Centralized CI: The new ci.yml workflow centralizes essential checks (lint, build, unit, visual tests) into a single, cohesive workflow, simplifying monitoring and ensuring consistency across all pull requests and pushes to leader.
• Improved Deployment Reliability: Switching deploy.yml to trigger on workflow_run.completed with a conclusion == 'success' is a robust pattern. It ensures that deployments only proceed after all defined CI checks have passed for a specific commit, reducing the risk of deploying broken code.
• Efficient Resource Usage: The concurrency setting in ci.yml helps prevent redundant CI runs and cancels in-progress runs for the same PR, which is crucial for managing self-hosted runner resources.
• Clear Responsibility: The ci-gate job clearly signals the overall success or failure of the CI pipeline, providing a single point of truth for commit status.
• Test Reporting: Continued use of dorny/test-reporter and actions/upload-artifact ensures clear visibility into test results and access to debugging logs/reports.
• Code Clean-up: Removing duplicated unit-tests and visual-tests jobs from pr-quality-standalone.yml reduces redundancy and makes the CI configuration easier to manage.

Issues

• None Blocking.

Test Coverage

The PR itself is a change to the CI/CD infrastructure, not application code. The new ci.yml workflow explicitly includes steps to run existing unit and visual test suites, ensuring that the project's test coverage strategy is maintained and enforced. Test results are published and artifacts uploaded as before, allowing for clear visibility into test outcomes.

Recommendations

• Documentation Update: Consider updating docs/DEVELOPMENT.md to reflect the new primary ci.yml workflow for linting, building, and testing, and how it integrates with the deployment process. Specifically, clarify the distinction between pr-quality.yml (if it still exists for standalone checks) and the new comprehensive ci.yml. This would provide a clearer overview of the CI/CD architecture for new contributors.

Verdict

Ready for approval.

Reviewed at commit: 93a8531a8a108a55c7aeccc21ce47cd0364ea5eb

[arii]

📋 Quality Gate Results

Check	Status
Knip	✅ success
Lint	✅ success
Build	❌ cancelled
Infra Tests	❌ cancelled
Unit Tests	❌ cancelled
Perf Tests	❌ cancelled
Visual Tests	❌ cancelled

❌ Build Failure Details

   - Environments: .env.local

   Creating an optimized production build ...
 ✓ Compiled successfully in 8.0s
   Running TypeScript ...
   Collecting page data using 3 workers ...
   Generating static pages using 3 workers (0/27) ...
   Generating static pages using 3 workers (6/27) 
   Generating static pages using 3 workers (13/27) 
   Generating static pages using 3 workers (20/27) 
 ✓ Generating static pages using 3 workers (27/27) in 957.7ms
   Finalizing page optimization ...

Route (app)
┌ ○ /
├ ○ /_not-found
├ ƒ /api/auth/[...nextauth]
├ ƒ /api/debug/auth-check
├ ƒ /api/debug/ping
├ ƒ /api/debug/reset
├ ƒ /api/debug/session
├ ƒ /api/debug/spotify-token
├ ƒ /api/debug/spotify-token-status
├ ƒ /api/health/detailed
├ ƒ /api/health/simple
├ ƒ /api/internal/clear-token
├ ƒ /api/internal/token-delivery
├ ƒ /api/spotify/access-token
├ ƒ /api/spotify/control
├ ƒ /api/spotify/devices
├ ƒ /api/spotify/playlists
├ ƒ /api/spotify/playlists/[playlistId]
├ ƒ /api/spotify/playlists/[playlistId]/tracks
├ ƒ /api/spotify/playlists/search
├ ƒ /api/spotify/search
├ ƒ /api/users
├ ƒ /api/workout
├ ○ /client/connect
├ ○ /client/control
├ ○ /client/mock
├ ○ /client/spotify-selection
├ ○ /debug/spotify
└ ƒ /spotify/playlist/[playlistId]


ƒ Proxy (Middleware)

○  (Static)   prerendered as static content
ƒ  (Dynamic)  server-rendered on demand

❌ Infrastructure Test Failure Details

Log file not found.

❌ Unit Test Failure Details

Log file not found.

❌ Visual Test Failure Details

Log file not found.

❌ Performance Test Failure Details

Log file not found.

⚠️ Some checks failed. Full logs available in workflow artifacts.

---

Report generated for commit: 0876276435db7a5a35c11ee1b904213369f90523

[arii]

Reviewed commit: 0876276435db7a5a35c11ee1b904213369f90523

Summary

This Pull Request introduces a new, comprehensive Continuous Integration (CI) workflow (ci.yml) and refactors existing deployment and standalone quality workflows. The primary goal is to centralize and automate unit and visual testing as part of the main CI pipeline for both pushes to leader and pull requests. It also correctly updates the deploy.yml workflow to trigger only upon the successful completion of the new CI workflow, significantly improving deployment reliability.

Strengths

• Consolidated CI Logic: The new ci.yml centralizes core linting, building, unit testing, and visual testing, leading to a more streamlined and reliable CI process.
• Enhanced Deployment Safety: The deploy.yml workflow now correctly depends on the successful completion of the Continuous Integration workflow, ensuring that only thoroughly validated code is deployed. This is a critical improvement for production stability.
• Robust Workflow Configuration: The workflows utilize self-hosted runners, continue-on-error: true for test steps (allowing reports to be published even on failure), if: always() for artifact uploads, timeout-minutes for job limits, and concurrency management, all of which are excellent practices for resilient GitHub Actions.
• Improved Maintainability: By removing redundant unit-tests and visual-tests jobs from pr-quality-standalone.yml, the project reduces duplication and makes the CI/CD configuration easier to manage.
• Alignment with Project Goals: This PR directly addresses the "Test Suite Optimization" and "Code Quality & Documentation" goals outlined in docs/DEVELOPMENT.md by enhancing test automation infrastructure.

Issues

No blocking issues were found. The changes are well-implemented and significantly improve the project's CI/CD pipeline.

Test Coverage

The automated test coverage alert is a false positive in this context, as this PR implements the testing workflows themselves rather than modifying application source code that would require new unit tests. The PR's purpose is to improve the mechanism by which tests are run and reported. The updated CI includes dedicated jobs for unit-tests and visual-tests which is a direct improvement in test coverage infrastructure.

Recommendations

None at this time. The PR is solid.

Verdict

✅ Verified the implementation of new CI workflows and the refactoring of existing ones. No regressions or new issues were found. The changes significantly enhance the project's CI/CD robustness and testing capabilities. Ready for approval.

Reviewed at commit: 0876276435db7a5a35c11ee1b904213369f90523

[arii]

@jules-new

[arii]

@pr-squash

[arii]

@pr-squash-rebase

[github-actions]

❌ Automatic squash and rebase failed. The branch has conflicts with leader. Please resolve the conflicts manually and try again.

[arii]

@Gemini-bot

[github-actions]

❌ Automatic squash and rebase failed. The branch has conflicts with leader. Please resolve the conflicts manually and try again.