-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add LinqraftMappingGenerate attribute for EFCore query compilation support #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d442ca7
Initial plan
Copilot c5f3e19
Add LinqraftMappingGenerate attribute and detection logic
Copilot 314dcfc
Implement extension method generation for LinqraftMappingGenerate
Copilot 6ba70dc
Add documentation and additional tests for LinqraftMappingGenerate
Copilot 7300fec
Address PR feedback: refocus docs, fix attribute detection, improve t…
Copilot d40fad6
Move mapping generation logic to Linqraft.Core and improve code organ…
Copilot d526d6c
Refactor mapping class code generation: streamline header and namespa…
arika0093 2572fcd
Fix namespace declaration in Issue_NestedSelectExprTest
arika0093 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
|
|
||
| namespace Linqraft.Core; | ||
|
|
||
| /// <summary> | ||
| /// Information about a method marked with [LinqraftMappingGenerate] attribute | ||
| /// </summary> | ||
| public record SelectExprMappingInfo | ||
| { | ||
| /// <summary> | ||
| /// The method declaration with the attribute | ||
| /// </summary> | ||
| public required MethodDeclarationSyntax MethodDeclaration { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The name of the method to generate (from attribute parameter) | ||
| /// </summary> | ||
| public required string TargetMethodName { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The containing class (must be static partial) | ||
| /// </summary> | ||
| public required INamedTypeSymbol ContainingClass { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The semantic model for this method | ||
| /// </summary> | ||
| public required SemanticModel SemanticModel { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The namespace where the class is defined | ||
| /// </summary> | ||
| public required string ContainingNamespace { get; init; } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the explanation to focus on "implementing the Select method within a class" without prominently featuring EFCore support. The file name should also be changed accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 7300fec. Renamed file to
mapping-methods.mdand refocused documentation on "implementing Select methods within a class." EFCore support is now presented as one use case among several (reusability, organization, testability). The documentation now emphasizes general usage patterns first before showing EFCore-specific scenarios.