Tests failing on live by arianakataokatesting · Pull Request #19 · ariskataoka/vipgoci-tests

arianakataokatesting · 2021-07-16T06:00:05Z

No description provided.

ariskataoka

phpcs scanning turned up:

🚫 7 errors

⚠️ 2 warnings

hashes-api-scanning skipped

ariskataoka · 2021-09-14T08:36:07Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


⚠️ Warning: Detected usage of a non-sanitized input variable: $_POST['phpcs should catch this problem'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$_POST['phpcs should catch this problem']' (WordPress.Security.EscapeOutput.OutputNotEscaped).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Processing form data without nonce verification (WordPress.Security.NonceVerification.Missing).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_POST['phpcs should catch this problem']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile1.php

+
+
+
+echo 'linter will catch this fatal;


🚫 Error: PHP syntax error: syntax error, unexpected ''linter will catch this fatal;' (T_ENCAPSED_AND_WHITESPACE) (Generic.PHP.Syntax.PHPSyntax).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


⚠️ Warning: Detected usage of a non-sanitized input variable: $_POST['phpcs should catch this problem'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$_POST['phpcs should catch this problem']' (WordPress.Security.EscapeOutput.OutputNotEscaped).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Processing form data without nonce verification (WordPress.Security.NonceVerification.Missing).

ariskataoka · 2021-09-14T08:36:08Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_POST['phpcs should catch this problem']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

ariskataoka

phpcs scanning turned up:

🚫 7 errors

⚠️ 2 warnings

hashes-api-scanning skipped

ariskataoka · 2021-09-15T08:27:59Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


⚠️ Warning: Detected usage of a non-sanitized input variable: $_POST['phpcs should catch this problem'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

ariskataoka · 2021-09-15T08:27:59Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$_POST['phpcs should catch this problem']' (WordPress.Security.EscapeOutput.OutputNotEscaped).

ariskataoka · 2021-09-15T08:27:59Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Processing form data without nonce verification (WordPress.Security.NonceVerification.Missing).

ariskataoka · 2021-09-15T08:27:59Z

tests1/myfile1.php

@@ -0,0 +1,17 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_POST['phpcs should catch this problem']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

ariskataoka · 2021-09-15T08:27:59Z

tests1/myfile1.php

+
+
+
+echo 'linter will catch this fatal;


🚫 Error: PHP syntax error: syntax error, unexpected ''linter will catch this fatal;' (T_ENCAPSED_AND_WHITESPACE) (Generic.PHP.Syntax.PHPSyntax).

ariskataoka · 2021-09-15T08:28:00Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


⚠️ Warning: Detected usage of a non-sanitized input variable: $_POST['phpcs should catch this problem'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

ariskataoka · 2021-09-15T08:28:00Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$_POST['phpcs should catch this problem']' (WordPress.Security.EscapeOutput.OutputNotEscaped).

ariskataoka · 2021-09-15T08:28:00Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Processing form data without nonce verification (WordPress.Security.NonceVerification.Missing).

ariskataoka · 2021-09-15T08:28:00Z

tests1/myfile2.php

@@ -0,0 +1,8 @@
+<?php
+
+echo $_POST[ 'phpcs should catch this problem' ];


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_POST['phpcs should catch this problem']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

ariskataoka

hashes-api-scanning skipped

skipped-files

Maximum number of lines exceeded (7):

GoogleAtom.php
MySuccessClass.php
MySuccessClass2.php
tests1/myfile1.php
tests1/myfile2.php

Note that the above file(s) were not analyzed due to their length.

ariskataoka

hashes-api-scanning skipped

skipped-files

Maximum number of lines exceeded (7):

GoogleAtom.php
MySuccessClass.php
MySuccessClass2.php
tests1/myfile1.php
tests1/myfile2.php

Note that the above file(s) were not analyzed due to their length.

ariskataoka

hashes-api-scanning skipped

skipped-files

Maximum number of lines exceeded (7):

GoogleAtom.php
MySuccessClass.php
MySuccessClass2.php
tests1/myfile1.php
tests1/myfile2.php

Note that the above file(s) were not analyzed due to their length.

ariskataoka

hashes-api-scanning skipped

skipped-files

Maximum number of lines exceeded (7):

Note that the above file(s) were not analyzed due to their length.

ariskataoka · 2021-10-25T06:21:16Z

PHP Syntax Errors Found

Scan performed on the code at commit 1d23f43 (view code).

Error: syntax error, unexpected end of file, expecting ; or ,

https://github.com/ariskataoka/vipgoci-tests/blob/1d23f431bdcc5fd69b9ff1c7511d654aa5ddebc7/src/SyntaxError.php#L4

ariskataoka

hashes-api-scanning skipped

ariskataoka requested changes Sep 14, 2021

View reviewed changes

ariskataoka force-pushed the tests/add-errors-phpunit branch from 955008c to 44a73c0 Compare September 14, 2021 09:18

Tests failing on live

1d23f43

ariskataoka force-pushed the tests/add-errors-phpunit branch from 4b49f6c to 1d23f43 Compare September 14, 2021 09:24

ariskataoka requested changes Sep 15, 2021

View reviewed changes

ariskataoka reviewed Oct 25, 2021

View reviewed changes

		@@ -0,0 +1,17 @@
		<?php

		echo $_POST[ 'phpcs should catch this problem' ];

		@@ -0,0 +1,8 @@
		<?php

		echo $_POST[ 'phpcs should catch this problem' ];

Conversation

arianakataokatesting commented Jul 16, 2021

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Maximum number of lines exceeded (7):

Uh oh!

ariskataoka commented Oct 25, 2021

Uh oh!

ariskataoka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants