Skip to content

Introduce problems#7

Open
arianakataokatesting wants to merge 1 commit intomainfrom
tests/one-more-new-1
Open

Introduce problems#7
arianakataokatesting wants to merge 1 commit intomainfrom
tests/one-more-new-1

Conversation

@arianakataokatesting
Copy link
Collaborator

@arianakataokatesting arianakataokatesting commented May 13, 2021

No description provided.

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**VIPGOCI_STATS_SKIPPED_FILES** due to exceeded number of lines (15000):
  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**VIPGOCI_STATS_SKIPPED_FILES** due to exceeded number of lines (15000):
  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**skipped-files** due to exceeded number of lines (15000):
  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**skipped-files**- Files exceeded the limit of number of lines (15000):
  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**skipped-files**- Files exceeded the limit of number of lines (15000):
  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

**any**

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

any

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

----skipped-files - Files exceeded the limit of number of lines (15000):

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

      • skipped-files - Files exceeded the limit of number of lines (15000):

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

*****skipped-files - Files exceeded the limit of number of lines (15000):

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files - Files exceeded the limit of number of lines (15000):

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines! (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the limit of number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the maximum number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the maximum number of lines (15000)

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the maximum number of lines (15000)

  • issues
  • total

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the maximum number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 13, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Files exceeded the maximum number of lines (15000)

  • src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Maximum number of lines exceeded (15000)

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Maximum number of lines exceeded (15000)

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Maximum number of lines exceeded (15000)

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files- Maximum number of lines exceeded (15000)
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-

ariskataoka
ariskataoka reviewed May 14, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 19, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 20, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 20, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 20, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php-src/MyFailedClass2.php-src/MyFailedClass.php-src/MyFailedClass2.php

ariskataoka
ariskataoka reviewed May 20, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php-src/MyFailedClass2.php

ariskataoka
ariskataoka reviewed May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

@ariskataoka ariskataoka force-pushed the tests/one-more-new-1 branch from aa1ec9e to fc521ac Compare May 21, 2021 01:05
ariskataoka
ariskataoka requested changes May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

src/MyFailedClass3.php
public function test(): string
{
echo 'asdf'
}
Copy link
Owner

@ariskataoka ariskataoka May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: PHP syntax error: syntax error, unexpected '}', expecting ';' or ',' (Generic.PHP.Syntax.PHPSyntax).

ariskataoka
ariskataoka reviewed May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

@ariskataoka ariskataoka force-pushed the tests/one-more-new-1 branch from fc521ac to 1bbc733 Compare May 21, 2021 03:42
ariskataoka
ariskataoka requested changes May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 2 errors

⚠️ 1 warning

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

src/MyFailedClass3.php
public function test(): string
{
echo 'asdf'
}
Copy link
Owner

@ariskataoka ariskataoka May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: PHP syntax error: syntax error, unexpected '}', expecting ';' or ',' (Generic.PHP.Syntax.PHPSyntax).

src/MyFailedClass4.php
{
public function test(): string
{
$functionsCookies = $_COOKIE;
Copy link
Owner

@ariskataoka ariskataoka May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning: Unused variable $functionsCookies (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable).

src/MyFailedClass4.php
{
public function test(): string
{
$functionsCookies = $_COOKIE;
Copy link
Owner

@ariskataoka ariskataoka May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead (WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE).

ariskataoka
ariskataoka reviewed May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 21, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed May 25, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

Maximum number of lines exceeded (15000)-
src/MyFailedClass.php

ariskataoka
ariskataoka reviewed Jun 11, 2021
View reviewed changes
Copy link
Owner

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes-api-scanning skipped

skipped-files
Maximum number of lines exceeded (15000):
-src/MyFailedClass.php
-src/MyFailedClass.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ariskataoka ariskataoka ariskataoka requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arianakataokatesting @ariskataoka