-
Notifications
You must be signed in to change notification settings - Fork 272
Doc: Update terminology for Arista AVD data models #6202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Update terminology for Arista AVD data models #6202
Conversation
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6202
# Activate the virtual environment
source test-avd-pr-6202/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carlbuchmann/avd.git@doc-avd-inputs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carlbuchmann/avd.git#/ansible_collections/arista/avd/,doc-avd-inputs --force
# Optional: Install AVD examples
cd test-avd-pr-6202
ansible-playbook arista.avd.install_examples |
5910373 to
933280f
Compare
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/input-variables.md
Outdated
Show resolved
Hide resolved
|
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/data-models.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/input-variables.md
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
54d4daa to
3904617
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3904617 to
d31d4dd
Compare
eb477c7 to
18bc8a3
Compare
ankudinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd consider some minor fixes
ansible_collections/arista/avd/examples/campus-fabric/README.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/data-models.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/data-models.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/overlay-settings.md
Show resolved
Hide resolved
...pyavd/_eos_designs/schema/schema_fragments/custom_structured_configuration_prefix.schema.yml
Show resolved
Hide resolved
joelbreton2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
0176a8e to
4d523c8
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
523c52b to
ca2e177
Compare
|
There are two hard links to the specific AVD version mentioning |
for more information, see https://pre-commit.ci
@joelbreton2 will address this in PR #6311 |
|
Co-authored-by: Petr Ankudinov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Petr Ankudinov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Petr Ankudinov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>



Change Summary
Update terminology for Arista AVD data models
eos_designs -> AVD Design
eos_cli_config_gen -> EOS Config
input variables -> data models
input variables for eos_design -> AVD Design data model
input variables for eos_cli_config_gen -> EOS Config data model
How to test
Review the documentation: https://ansible-avd--6202.org.readthedocs.build/en/6202/docs/data-models/index.html