Modified meteoservice.rb to parse cities and their indexes from json file#30
Open
TimKm wants to merge 2 commits intoaristofun:masterfrom
Open
Modified meteoservice.rb to parse cities and their indexes from json file#30TimKm wants to merge 2 commits intoaristofun:masterfrom
TimKm wants to merge 2 commits intoaristofun:masterfrom
Conversation
added json file that contains the name of the cities with their corresponding index on (https://www.meteoservice.ru/content/export.html)
Cities with their corresponding indexes are parsed from cities.json file now. It is done in order to modify the json file itself and not to tackle with the main code. As well this practice was taught in previous lessons. Aside of that, changed statement "unless" to "until". With "unless" if the user enters wrong input second time then the program would continue and crash, while with "until" it will prompt user to enter the number again and again until the correct one is matched the condition.
aristofun
requested changes
Jan 16, 2021
Owner
aristofun
left a comment
aristofun
left a comment
There was a problem hiding this comment.
Good improvement but inline CITIES back please. It’s important to keep newcomers simple.
Until they explicitly would need json, for example.
| require 'json' | ||
|
|
||
| require_relative 'lib/meteoservice_forecast' | ||
| require_relative 'data/cities.json' |
Owner
There was a problem hiding this comment.
Why is it required?
please inline it for simplicity
| puts "#{index+1}: #{name.first}" | ||
| end | ||
|
|
||
| city_index = gets.chomp.to_i |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As well fixed a bug which crashed the program in case if user enters wrong value second time.
BEFORE:
AFTER: