Correct the length of data that has been sent#40
Open
mokeyish wants to merge 1 commit intoark0f:masterfrom
Open
Correct the length of data that has been sent#40mokeyish wants to merge 1 commit intoark0f:masterfrom
mokeyish wants to merge 1 commit intoark0f:masterfrom
Conversation
ark0f
reviewed
Mar 8, 2024
ark0f
reviewed
Apr 2, 2024
| let bytes_size = Self::get_buf_size(addr.size(), buf.len()); | ||
| let bytes = Vec::with_capacity(bytes_size); | ||
| async fn write_request(buf: &[u8], addr: AddrKind) -> Result<(Vec<u8>, usize)> { | ||
| let header_size = Self::get_header_size(addr.size()); |
Owner
There was a problem hiding this comment.
You can get header size just via cursor like it done in read_response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some codes will check the length of bytes sent. If the length of socks5's header is included, the verification will fail.