Skip to content

Conversation

louisinger
Copy link

@louisinger louisinger commented Oct 13, 2025

This PR includes two fixes to build_offchain_transactions.

TaprootTree encoding

Firstly, it fixes the taproot tree encoding by removing the extra write_compact_size_uint at the beginning of the serialization. That's something we introduced recently to be compliant with orignal taptree encoding: arkade-os/arkd#717 (the PR also contains a fixture to unit test it).

Add checkpoint_script to taproot tree

While encoding the scripts added to the off chain transaction as VTXO_TAPROOT_KEY unknown field, the checkpoint_script must also be included. That's something we need to verify server-side (once arkade-os/arkd#757 merged, it will fail if checkpoint_script is not included)

Please forgive my Rust code

@luckysori please review

Copy link

coderabbitai bot commented Oct 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • next-version

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@louisinger louisinger requested a review from luckysori October 13, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant