Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes to
build_offchain_transactions
.TaprootTree encoding
Firstly, it fixes the taproot tree encoding by removing the extra
write_compact_size_uint
at the beginning of the serialization. That's something we introduced recently to be compliant with orignal taptree encoding: arkade-os/arkd#717 (the PR also contains a fixture to unit test it).Add
checkpoint_script
to taproot treeWhile encoding the scripts added to the off chain transaction as
VTXO_TAPROOT_KEY
unknown field, thecheckpoint_script
must also be included. That's something we need to verify server-side (once arkade-os/arkd#757 merged, it will fail if checkpoint_script is not included)Please forgive my Rust code
@luckysori please review