Skip to content

Ark-ff Small Field Support #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Ark-ff Small Field Support #1044

wants to merge 36 commits into from

Conversation

@benbencik
Copy link

@benbencik benbencik commented Oct 8, 2025 •
edited by z-tech
Loading

Description

This PR adds SmallFp, a procedural macro for instantiating prime fields with modulus < 2^127 using native integer types (u8, u16, u32, u64, u128).

Closes: #1038

This work was done in collaboration with @z-tech

z-tech and others added 24 commits September 4, 2025 12:13
@z-tech
placeholder for SmallFp
7b49928
@benbencik
migrate smallfp implementation from blendy
daa99f7
@benbencik
add tests
0fadbb9
@benbencik
add benchmarks
3d6636e
@benbencik
add square root precomputation
f7de469
@benbencik
split sampling method into cases
4d835f4
@benbencik
fix mul overflow issue
4ba1448
@benbencik
extend testing suite (some tests failing)
d1937cc
@benbencik
rewrite sampling function
a1a3343
@benbencik
fix overflowing bug in multiplication
9cc57f5
@benbencik
fix the computation for bit size
be2664d
@benbencik
consider (de)serialization of small elements
e39da81
@benbencik
rewrite computation for two adic root of unity
3c7daf9
@benbencik
use safe mul to avoid overflows in compile-time
8a907d8
@benbencik
update the smallfp tests
ea4cce2
@benbencik
Merge branch 'smallfp-test' into small_fp
db896d3
@benbencik
rewrite mul_assing to handle overflows correctly
2945217
@benbencik
move tests and benches to test-curves
582ac3d
@benbencik
update doccomments
b91c704
@benbencik
use the provided bench templates for fields
f2f3fb1
@benbencik
Merge branch 'master' into small_fp
f8c81e8
@benbencik
add info about small fields to readme
176fc97
@benbencik
add pending PR 1044
0cad96a
@benbencik
fix markdown linter error
742bb39
@benbencik benbencik marked this pull request as ready for review October 9, 2025 10:07
@benbencik benbencik requested review from a team as code owners October 9, 2025 10:07
@benbencik benbencik requested review from Pratyush and z-tech and removed request for a team October 9, 2025 10:07
@benbencik benbencik requested a review from mmagician October 9, 2025 10:07
z-tech
z-tech reviewed Oct 13, 2025
View reviewed changes
z-tech
z-tech reviewed Oct 13, 2025
View reviewed changes
@z-tech z-tech requested review from mmaker and weikengchen October 14, 2025 11:41
@z-tech z-tech changed the title Small field implementation Ark-ff Small Field Support Oct 14, 2025
@z-tech z-tech mentioned this pull request Oct 14, 2025
Closed
@Pratyush
Copy link
Member

Pratyush commented Oct 14, 2025

Hm I would like to review this PR, but the current scope is quite massive. Is it possible to break it up into smaller PRs? E.g., first adding the backend, then adding the macros, then adding impls, or something similar?

@z-tech
Copy link
Contributor

z-tech commented Oct 15, 2025

Hm I would like to review this PR, but the current scope is quite massive. Is it possible to break it up into smaller PRs? E.g., first adding the backend, then adding the macros, then adding impls, or something similar?

No problem. We'll try to cut it up into a few chunks for reviewing.

This was referenced Oct 15, 2025
Draft
Closed
Draft
Draft
@benbencik
Copy link
Author

benbencik commented Oct 16, 2025

Hm I would like to review this PR, but the current scope is quite massive. Is it possible to break it up into smaller PRs? E.g., first adding the backend, then adding the macros, then adding impls, or something similar?

Hello, I added the following temporary PRs:

The CI fails in the last two PRs because we are missing the arithmetic implementation or the trait definition. When all of the changes are combined, the CI (including extended tests) passes successfully.

@z-tech
Copy link
Contributor

z-tech commented Oct 16, 2025

@Pratyush we're also happy to meet and explain the logical flow when/ if helpful.

Same for @weikengchen @mmaker (or any maintainers) if interested in reviewing just let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z-tech z-tech z-tech approved these changes

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@mmaker mmaker Awaiting requested review from mmaker

@weikengchen weikengchen Awaiting requested review from weikengchen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbencik @Pratyush @z-tech