Small Fields #78
Closed
Small Fields #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-tech
commented
Jul 11, 2025
z-tech
commented
Jul 11, 2025
z-tech
commented
Jul 11, 2025
z-tech
commented
Jul 11, 2025
z-tech
commented
Jul 11, 2025
|
Looking good! Did a first pass. I also bumped the arkworks versions to 0.5 (which has slightly different field interfaces) which I'm not sure why I forgot to do in the first place. In addition to the comments I've left, any dead code... any linter errors and comments that are no longer relevant please have a pass at removing and simplifying everything. I expect no big changes to what's here just to finish implementing and polish up the existing impls. Great work. |
|
This code has been moved to Algebra: arkworks-rs/algebra#1044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.