Const initialization helper for SmallFp#1084
Merged
weikengchen merged 11 commits intomasterfrom Mar 29, 2026
Merged
Conversation
z-tech
commented
Mar 29, 2026
| fn from_bigint(a: ark_ff::BigInt<2>) -> Option<SmallFp<Self>> { | ||
| let val = (a.0[0] as u128) + ((a.0[1] as u128) << 64); | ||
| if val > Self::MODULUS_U128 { | ||
| if val >= Self::MODULUS_U128 { |
Contributor
Author
There was a problem hiding this comment.
Both zero and the modulus would be mapped to zero if not changed to >=, which came up in serialization for spongefish.
z-tech
commented
Mar 29, 2026
| let (mut val, overflow) = a.value.overflowing_add(b.value); | ||
| if overflow { | ||
| val = Self::T::MAX - Self::MODULUS + 1 + val | ||
| val += Self::T::MAX - Self::MODULUS + 1 |
Contributor
Author
There was a problem hiding this comment.
Fixes downstream clippy warnings
z-tech
commented
Mar 29, 2026
|
|
||
| let field_ty = if is_small_modulus { | ||
| quote::quote! { ark_ff::SmallFp<#config_name> } | ||
| if is_small_modulus { |
Contributor
Author
There was a problem hiding this comment.
These changes fix the proc macro error given by rust analyzer
z-tech
changed the title
z-tech
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
weikengchen
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no equivalent const helper for MontFp! so we create NAME::from_u128(1) that is const compatible. This isn't strictly needed but it's far more convenient for users especially when writing extension field config.
Example use: https://github.com/WizardOfMenlo/whir/pull/242/changes#diff-a0fce05055298d8ce81ce601933b6e9349617338f89f53db251b60d5ff884182R95
Small Items:
closes: #1085
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer