Open
Conversation
Member
|
We should indeed deprecate fiat_shamir::AlgebraicSponge entirely |
Pratyush
reviewed
Mar 23, 2022
src/lib.rs
Outdated
Comment on lines
+10
to
+15
| //#![deny(unused_import_braces, unused_qualifications, trivial_casts)] | ||
| //#![deny(trivial_numeric_casts, private_in_public)] | ||
| //#![deny(stable_features, unreachable_pub, non_shorthand_field_patterns)] | ||
| //#![deny(unused_attributes, unused_imports, unused_mut)] | ||
| //#![deny(renamed_and_removed_lints, stable_features, unused_allocation)] | ||
| //#![deny(unused_comparisons, bare_trait_objects, unused_must_use, const_err)] |
Member
There was a problem hiding this comment.
We should change these to warns, like the main branch has
Collaborator
Author
There was a problem hiding this comment.
Ops, forgot these
Pratyush
approved these changes
Mar 23, 2022
Member
|
ideas to fix the test? |
weijiguo
reviewed
Sep 26, 2023
| /// The interface for a cryptographic sponge constraints on field `F`. | ||
| /// A sponge can `absorb` or take in inputs and later `squeeze` or output bytes or field elements. | ||
| /// The outputs are dependent on previous `absorb` and `squeeze` calls. | ||
| pub trait CryptographicSpongeVarNonNative<F: PrimeField, CF: PrimeField, S: CryptographicSponge>: |
There was a problem hiding this comment.
It does not seem this trait has been implemented in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The branch
constraintsisn't building with latest dependencies.Open questions
DensePolynomial<F>concretely in some places, and expect the genericPC::BatchProofin othersfiat_shamir::AlgebraicSpongelooks duplicate toark_sponge::CryptographicSpongeand should possibly be replacedcloses: #87
constraintsso the latter can be merged tomasterPendingsection inCHANGELOG.mdFiles changedin the Github PR explorer