Add serialize traits to LabeledCommitment#122
Closed
TakodaS wants to merge 2 commits intoarkworks-rs:masterfrom
Closed
Add serialize traits to LabeledCommitment#122TakodaS wants to merge 2 commits intoarkworks-rs:masterfrom
TakodaS wants to merge 2 commits intoarkworks-rs:masterfrom
Conversation
6 tasks
Member
|
I think we shouldn't do this, as the labels exist purely at runtime; the versions absorbed into the sponge should be the unlabelled commitments. |
Author
Having delved further into the marlin repo, I agree. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added CanonicalSerialize/Deserialize traits to the LabeledCommitment struct.
When poly-commit was updated to v0.4.0, the trait
ToByteswas removed from LabeledCommit but the Serialization traits were not added.Blocks arkworks-rs/marlin/pull/94 as LabeledCommit structs need to be absorbed by the sponge function to add entropy.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer