Skip to content

fix(vanishing_poly): compute x^2 - h^2 when dim_h == 1 in evaluate_constraints #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vanishing_poly): compute x^2 - h^2 when dim_h == 1 in evaluate_constraints #186

wants to merge 1 commit into from

Conversation

phrwlk
Copy link

@phrwlk phrwlk commented Aug 19, 2025

  • Align constraint evaluation with native evaluation for dim_h == 1 by returning x^2 - h^2 instead of 0.
  • Add a unit test constraints_test_dim1 in src/poly/domain/vanishing_poly.rs.
  • Remove unused import ark_std::ops::Sub to silence the warning.

Test/build pass

@phrwlk phrwlk requested a review from a team as a code owner August 19, 2025 08:17
@phrwlk phrwlk requested review from z-tech, Pratyush and weikengchen and removed request for a team August 19, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phrwlk