Skip to content

fix(pairing): clarify Miller loop comment to reference P::ATE_LOOP_COUNT #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(pairing): clarify Miller loop comment to reference P::ATE_LOOP_COUNT #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba67dc
fix(pairing): clarify Miller loop comment to reference P::ATE_LOOP_COUNT
Forostovec Oct 10, 2025
f3986cf
fix(pairing): clarify Miller loop comment to reference P::ATE_LOOP_COUNT
Forostovec Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pairing/mnt4/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ impl<P: MNT4Config> PairingVar<P> {

let mut add_idx: usize = 0;

// code below gets executed for all bits (EXCEPT the MSB itself) of
// mnt6_param_p (skipping leading zeros) in MSB to LSB order
// Iterate over P::ATE_LOOP_COUNT (signed in {-1, 0, 1}), skipping the MSB,
// in MSB-to-LSB order. Branches handle 1 and -1; a final correction is
// applied after the loop if P::ATE_IS_LOOP_COUNT_NEG.
let y_over_twist_neg = &q.y_over_twist.negate()?;
for (dbl_idx, bit) in P::ATE_LOOP_COUNT.iter().skip(1).enumerate() {
let dc = &q.double_coefficients[dbl_idx];
Expand Down
5 changes: 3 additions & 2 deletions src/pairing/mnt6/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ impl<P: MNT6Config> PairingVar<P> {

let mut add_idx: usize = 0;

// code below gets executed for all bits (EXCEPT the MSB itself) of
// mnt6_param_p (skipping leading zeros) in MSB to LSB order
// Iterate over P::ATE_LOOP_COUNT (signed in {-1, 0, 1}), skipping the MSB,
// in MSB-to-LSB order. Branches handle 1 and -1; a final correction is
// applied after the loop if P::ATE_IS_LOOP_COUNT_NEG.
let y_over_twist_neg = &q.y_over_twist.negate()?;
for (dbl_idx, bit) in P::ATE_LOOP_COUNT.iter().skip(1).enumerate() {
let dc = &q.double_coefficients[dbl_idx];
Expand Down