Skip to content

Ensure explicit R1CS presence checks in SR1CS adapter #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure explicit R1CS presence checks in SR1CS adapter #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion relations/src/sr1cs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ impl<F: Field> Sr1csAdapter<F> {
cs: &ConstraintSystemRef<F>,
) -> Result<ConstraintSystemRef<F>, SynthesisError> {
assert_eq!(cs.num_predicates(), 1);
assert!(cs.has_predicate(R1CS_PREDICATE_LABEL));
let matrices = &cs.to_matrices().unwrap()[R1CS_PREDICATE_LABEL];
let mut public_variables = BTreeMap::new();
let mut witness_variables = BTreeMap::new();
Expand Down Expand Up @@ -187,10 +188,11 @@ impl<F: Field> Sr1csAdapter<F> {
///
/// # Panics
///
/// Panics is the constraint system does not have the R1CS predicate registered.
/// Panics if the constraint system does not have the R1CS predicate registered.
pub fn r1cs_to_sr1cs_with_assignment(
cs: &mut ConstraintSystem<F>,
) -> Result<ConstraintSystemRef<F>, SynthesisError> {
assert!(cs.has_predicate(R1CS_PREDICATE_LABEL));
let matrices = &cs.to_matrices().unwrap()[R1CS_PREDICATE_LABEL];
let mut public_variables = BTreeMap::new();
let mut witness_variables = BTreeMap::new();
Expand Down