Skip to content

Conversation

@ajkeller34
Copy link

@ajkeller34 ajkeller34 commented Jul 5, 2019

I split this out into a separate PR because I wasn't sure if this was an intentional decision on your part, but I wanted to suggest removing the upper limits on dependency versions. I think as written before this PR, the syntax implies the exact versions are required. edit: it does not. Some minor explanations:

  • I believe the caret ^ I added in front of the Julia version just means your package will be permitted to work with any version of Julia ≥ 1.0 and < 2.0, when Julia is next allowed to make breaking changes. edit: this is already the default behavior
  • It would at least be nice to loosen the bound on ConvexBodyProximityQueries, if not ≥ 0.1 as I've done below then ^0.1 so that versions up to 0.2 are available. edit: this is already the default behavior
  • The other packages are pretty well developed but still not declared as 1.0; it is possible changes made there could cause problems here, but if it happens, you can make a PR to JuliaRegistries/General to retroactively upper-bound the compatibility.

I made this PR because I had some conflict where I couldn't add your package the first time I tried it; another package I was using in the same environment wanted StaticArrays v0.11.

@ajkeller34 ajkeller34 changed the title Compatibility in Project.toml wip: Compatibility in Project.toml Jul 5, 2019
@ajkeller34
Copy link
Author

Hmm, wasn't expecting the test failure, so definitely don't merge this for now...

@ajkeller34
Copy link
Author

I'm still getting up to speed with understanding the Project.toml files and all that, so sorry for the noise. In any case, the PR is now much more conservative and just allows the package to work with StaticArrays 0.11 in addition to 0.10.

@ajkeller34 ajkeller34 closed this Jul 5, 2019
@ajkeller34 ajkeller34 reopened this Jul 5, 2019
arlk added a commit to arlk/ConvexBodyProximityQueries.jl that referenced this pull request Jul 5, 2019
This should fix the test failure in arlk/CurveProximityQueries.jl#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant