[Downstream change][tests] Mark the tests failing with timeout as unsupported #178
Conversation
…upported Initial upstream attempt: llvm/llvm-project#126527 Downstream issue: #177 There are some test cases which tend to fail with timeout when started on heavy loaded shared machines. As our CI machines are mostly shared, those failures tend to introduce unnecessary disturbance to our work. It is better to disable those tests. For more context, please read issue #177.
pawosm-arm
requested review from
DaftanoPro,
DavidTruby,
dcandler,
pratlucas,
schander-arm and
voltur01
dcandler
left a comment
dcandler
left a comment
There was a problem hiding this comment.
I'm not sure we should use a downstream change to disable the tests for everyone if it's a problem that only affects our CI because we're knowingly overloading the machines.
Do we have to modify the sources to not run these tests in our builds? Lit provides the option to filter out tests either by the command line or environment variable (https://llvm.org/docs/CommandGuide/lit.html#cmdoption-lit-filter-out). Could that not be used to skip the tests in our CI, at the point when tests are run?
|
@dcandler I need your advice here. If we start the tests like this: how can I pass the |
I don't think you can, which is why the |
|
Closing it as we really don't want to introduce a downstream change. |
Initial upstream attempt: llvm/llvm-project#126527
Downstream issue: #177
There are some test cases which tend to fail with timeout when started on heavy loaded shared machines. As our CI machines are mostly shared, those failures tend to introduce unnecessary disturbance to our work. It is better to disable those tests.
For more context, please read issue #177.