[ATfL] build.sh modification to generate flang/armflang manpages #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawosm-arm
requested review from
DavidTruby,
dcandler,
garyjcarroll,
pratlucas,
schander-arm and
voltur01
Contributor
Author
|
This PR had to wait until a fix for generating flang manpages has landed upstream. |
kiranchandramohan
approved these changes
Jun 6, 2025
Contributor
kiranchandramohan
left a comment
kiranchandramohan
left a comment
There was a problem hiding this comment.
LG. Have one question.
| -DCMAKE_SKIP_RPATH=No | ||
| -DCMAKE_SKIP_INSTALL_RPATH=No | ||
| -DLLVM_BUILD_DOCS=ON | ||
| -DFLANG_INCLUDE_DOCS=OFF |
Contributor
There was a problem hiding this comment.
Why are we switching this off? This is also not mentioned in the summary.
Contributor
Author
There was a problem hiding this comment.
We were switching it OFF as it used to fail before a recent upstream change has merged. Now in this commit I'm removing the line that switched generating the flang pages off.
Contributor
Author
There was a problem hiding this comment.
I've added a reference to the relevant upstream PR in this PR commit message.
Contributor
Author
Answered (and updated the commit message with relevant information) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes disablement of generating the flang docs (man pages). It was disabled as it had been failing. We had to wait until a fix for generating flang manpages has landed upstream. See llvm/llvm-project#141882