[Downstream change] Backport of [LLVM][SROA] Teach SROA how to "bitcast" between fixed and scalable vectors. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectors. (#130973) For function whose vscale_range is limited to a single value we can size scalable vectors. This aids SROA by allowing scalable vector load and store operations to be considered for replacement whereby bitcasts through memory can be replaced by vector insert or extract operations.
pawosm-arm
requested review from
dcandler,
kiranchandramohan,
paulwalker-arm,
pratlucas and
voltur01
Contributor
|
I assume the new change is not on the upstream 20.x branch and we cannot add it there, thus we still need the downstream change. The only comment is then we need to still track this as a downstream change, similarly to the reverted commit. |
paulwalker-arm
approved these changes
Jun 25, 2025
Contributor
paulwalker-arm
left a comment
paulwalker-arm
left a comment
There was a problem hiding this comment.
The code changes look consistent to me.
pawosm-arm
changed the title
Contributor
Author
I've updated the title and the initial comment. |
pratlucas
deleted the
users/pawosm-arm/release/arm-software/20.x/llvm-sroa-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
Downstream issue: #218