[RFC] Set C library for libc++ to avoid including extra headers #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prototype (i.e. not intended to be merged directly) to avoid downstream change arm#378 and solve the issue of including picolibc.h or newlib.h directly. It makes use of CMake LIBCXX_LIBC option to set the library at build time and generate C defines to detect the C library in C++ code. This works with picolibc and newlib. llvm-libc option cannot be enabled yet, because it causes extra command line options to be passed to libcxxabi that is added in ATfE CMake in one step with libcxx itself - needs a refactoring to split these.
|
Was discussed in the libc++ monthly sync on 08-07-2025 and agreed that it is an acceptable approach. |
|
Upstream PR llvm/llvm-project#147956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype (i.e. not intended to be merged directly) to avoid downstream change #378 and solve the issue of including picolibc.h or newlib.h directly.
It makes use of CMake LIBCXX_LIBC option to set the library at build time and generate C defines to detect the C library in C++ code.
This works with picolibc and newlib. llvm-libc option cannot be enabled yet, because it causes extra command line options to be passed to libcxxabi that is added in ATfE CMake in one step with libcxx itself - needs a refactoring to split these.