Skip to content

[Downstream change] Cherry-pick of [TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

[Downstream change] Cherry-pick of [TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" #535

merged 3 commits into from
Sep 22, 2025

Conversation

@pawosm-arm
Copy link
Contributor

@pawosm-arm pawosm-arm commented Sep 15, 2025 •
edited
Loading

Original PR under review: llvm/llvm-project#140070

This is an one off change for the ATfL21 release.

Downstream issue: #533

@MacDue @pawosm-arm
[TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-li…
cb58934 
…nux-gnu"

This normalizes the "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu",
this allows various parts of the LLVM codebase to recognize a GNU
environment is present on Amazon Linux. This allows RuntimeLibcalls to
mark the sincos* functions as available on Amazon Linux. This allows
these functions to be vectorized on Amazon Linux.
@MacDue @pawosm-arm
X86 test
fa09a04
@pawosm-arm pawosm-arm requested review from a team as code owners September 15, 2025 15:36
@github-actions github-actions bot added the downstream-change Downstream change to LLVM tree label Sep 15, 2025
@github-actions
Copy link

This pull review modifies files outside of the arm-software directory, so please ensure it follows the Downstream Patch Policy.
An automated check will test if the tagging requirements have been met. Please wait for approving reviews from both Arm Toolchain for Embedded and Arm Toolchain for Linux teams before merging.

@pawosm-arm pawosm-arm changed the title Users/pawosm arm/release/arm software/21.x/atfl amazon triple [Downstream change] Backport of [TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" Sep 15, 2025
@DavidTruby
Copy link
Contributor

This isn't strictly speaking a "Backport" because the patch isn't in upstream clang main, but rather a branch with a PR. I guess I'd be slightly concerned that the upstream patch is never actually going to get merged?

@pawosm-arm
Copy link
Contributor Author

I guess I'd be slightly concerned that the upstream patch is never actually going to get merged?

We're introducing it to the release branch only (following @MacDue recommendation). We decided this is how this should be addressed for this release.

@voltur01
Copy link
Contributor

@pawosm-arm do you want to update the description here and the issue #533 to point out that this is a one off change for 21.x branch, not a permanent downstream change moving forward?

@MacDue
Copy link
Contributor

MacDue commented Sep 17, 2025

It's unclear to me whether this is a one-off or not. As things stand the upstream patch seems unlikely to be merged.

@voltur01
Copy link
Contributor

It's unclear

Now this is on the release branch only, thus is easier to accept as it will not cause us merge conflicts. i.e. maintenance, in the future.

We will need a separate issue and PR to implement this same or similar change on the main arm-software branch if it will be needed later. Do not have to decide now.

@pawosm-arm
Copy link
Contributor Author

It's unclear

Now this is on the release branch only, thus is easier to accept as it will not cause us merge conflicts. i.e. maintenance, in the future.

We will need a separate issue and PR to implement this same or similar change on the main arm-software branch if it will be needed later. Do not have to decide now.

Fun fact, we (me and @kiranchandramohan) haven't been even discussing porting this change to the main arm-software branch. This is something we want for this release.

simpal01
simpal01 reviewed Sep 17, 2025
View reviewed changes
@pawosm-arm pawosm-arm changed the title [Downstream change] Backport of [TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" [Downstream change] Cherry-pick of [TargetParser] Normalize "aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" Sep 18, 2025
@pawosm-arm pawosm-arm requested a review from simpal01 September 22, 2025 09:37
@kiranchandramohan
Copy link
Contributor

@MacDue Could you conditionally accept the changes cherrypicked from your upstream patch. We are OK with this downstream change for ATfL release. Amazon also mentioned they have downstream changes for this.

I can approve formally for the release if @MacDue approves the code changes.

kiranchandramohan
kiranchandramohan approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. It is a simple cherry-pick of the upstream patch.

Note: @MacDue is on holidays.

@pawosm-arm pawosm-arm merged commit 956585f into release/arm-software/21.x Sep 22, 2025
2 checks passed
@pawosm-arm pawosm-arm deleted the users/pawosm-arm/release/arm-software/21.x/atfl-amazon-triple branch September 22, 2025 17:34
pawosm-arm added a commit that referenced this pull request Sep 23, 2025
@pawosm-arm
Revert "[Downstream change] Cherry-pick of [TargetParser] Normalize "…
89abdff 
…aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" (#535)"

This reverts commit 956585f.
@pawosm-arm pawosm-arm mentioned this pull request Sep 23, 2025
Closed
pawosm-arm added a commit that referenced this pull request Sep 25, 2025
@pawosm-arm
Revert "[Downstream change] Cherry-pick of [TargetParser] Normalize "…
2d25908 
…aarch64-amazon-linux" to "aarch64-amazon-linux-gnu" (#535)"

This reverts commit 956585f.
pawosm-arm added a commit that referenced this pull request Sep 25, 2025
@pawosm-arm
Revert "[Downstream change] Cherry-pick of [TargetParser] Normalize a…
1a397c6 
…arch64-amazon-linux" to "aarch64-amazon-linux-gnu" (#535)" (#545)

Removes downstream issue: #533

This reverts commit 956585f.

The frontend driver fails to find system-provided standard C++ library
with this.
@pawosm-arm pawosm-arm mentioned this pull request Sep 25, 2025
Merged
pawosm-arm added a commit that referenced this pull request Sep 25, 2025
@pawosm-arm @MacDue
[Downstream change] Cherry-pick of [TargetParser] Parse Amazon Linux …
bbe033f 
…triple and handle RuntimeLibcalls (#546)

Original PR under review: llvm/llvm-project#136114

As the commit introduced by #535 has resulted in a faulty C++ compiler
which could not see system-provided standard C++ library, an alternative
solution is now being cherry-picked here which appears to work with
Amazon Linux 2023.

This is an one off change for the ATfL21 release.

Downstream issue: #533

Co-authored-by: Benjamin Maxwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchandramohan kiranchandramohan kiranchandramohan approved these changes

@tblah tblah Awaiting requested review from tblah

@pratlucas pratlucas Awaiting requested review from pratlucas

@dcandler dcandler Awaiting requested review from dcandler

@voltur01 voltur01 Awaiting requested review from voltur01

@garyjcarroll garyjcarroll Awaiting requested review from garyjcarroll

@schander-arm schander-arm Awaiting requested review from schander-arm

@DavidTruby DavidTruby Awaiting requested review from DavidTruby

@simpal01 simpal01 Awaiting requested review from simpal01

Assignees

No one assigned

Labels

downstream-change Downstream change to LLVM tree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pawosm-arm @DavidTruby @voltur01 @MacDue @kiranchandramohan @simpal01