Ensure cache-control headers are always served for index.html response #4242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Lookout UI web server, the HTTP response headers preventing index.html from being served are only served when the document is accessed directly i.e. when navigating to "/" or "/index.html". They are not served when the document is returned in response to a request path which doesn't exist. (This behaviour is needed for single-page applications because the handling of 404s is deferred to the front end's client side routing.) This commit makes sure these headers are served for the latter as well as the former.
MustafaI
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Lookout UI web server, the HTTP response headers preventing index.html from being served are only served when the document is accessed directly i.e. when navigating to "/" or "/index.html". They are not served when the document is returned in response to a request path which doesn't exist. (This behaviour is needed for single-page applications because the handling of 404s is deferred to the front end's client side routing.)
This commit makes sure these headers are served for the latter as well as the former.