Skip to content

Conversation

@jparraga-stackav
Copy link

This pull request removes the default configuration which adds a priority class name override.

This configuration is puzzling to me since there is already a default priority class name set. I don't see why the intended priority class should be overridden when sent down to the executor. This can also conflict with the preemptible label that is unconditionally set prior to the priority class name override.

I mainly find this problematic because we are unable to unset this when managing Armada using the Armada Operator.

@dejanzele
Copy link
Member

@jparraga-stackav as Armada handles preemption, I described the flow here #4600

Is there a reason why you would attach different priority classes to pods?
This does not impact Armada scheduling and preemption anyhow.

@jparraga-stackav
Copy link
Author

Is there a reason why you would attach different priority classes to pods?
This does not impact Armada scheduling and preemption anyhow.

That is how the Armada Operator works since it supports creating priority classes from the config. If we remove that logic from the operator I'm fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants