Skip to content

Conversation

@nikola-jokic
Copy link
Contributor

What type of PR is this?

Enhancement

What this PR does / why we need it

When users submit jobs with ingresses, they have no way to see the resulting URLs in Lookout.

@nikola-jokic nikola-jokic force-pushed the nikola-jokic/lookout-ingress-addresses branch 2 times, most recently from de9b3e1 to a1386a7 Compare December 23, 2025 12:42
nikola-jokic and others added 6 commits January 5, 2026 15:00
Signed-off-by: Nikola Jokic <[email protected]>
Signed-off-by: Nikola Jokic <[email protected]>
Signed-off-by: Nikola Jokic <[email protected]>
…wnload latest armadactl (#4498)

#### What type of PR is this?

Chore / Bug fix

#### What this PR does / why we need it:

Fixes integration tests failing on new releases by building `armadactl`
from source instead of downloading from GitHub. Previously, tests would
fail because they tried to download release artifacts that hadn't been
uploaded yet.

The download script now fetches the latest release for local developers.

Signed-off-by: Dejan Zele Pejchev <[email protected]>
Signed-off-by: Nikola Jokic <[email protected]>
#### What type of PR is this?
Purely CI

#### What this PR does / why we need it:
Test results of pull requests from fork repositories are currently not
published. The current setup makes them fail:

    Resource not accessible by integration

https://github.com/armadaproject/armada/actions/runs/14449584216/job/40518701460#step:5:2282

This is because the CI is executed in the context of the fork
repository, where Github Actions does not have permissions to write to
the upstream pull request (required by the publish action).

#### Which issue(s) this PR fixes:
This applies the pattern documented at
https://github.com/mikepenz/action-junit-report#pr-run-permissions.

---------

Signed-off-by: Enrico Minack <[email protected]>
Signed-off-by: Nikola Jokic <[email protected]>
Signed-off-by: Nikola Jokic <[email protected]>
@nikola-jokic nikola-jokic force-pushed the nikola-jokic/lookout-ingress-addresses branch from ab76a0a to dd3ed1c Compare January 5, 2026 14:00
@JamesMurkin JamesMurkin merged commit 56aca92 into master Jan 8, 2026
26 of 27 checks passed
@JamesMurkin JamesMurkin deleted the nikola-jokic/lookout-ingress-addresses branch January 8, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants