Skip to content

Label on approved is running with wrong permissions #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Label on approved is running with wrong permissions #8085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pr-label-on-approved.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
on: pull_request_review
name: Label approved pull requests
name: "Label approved pull requests"
on: pull_request_target

permissions:
contents: read # Required for checking changed files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this PR, but I don't think this permission is needed in this workflow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those permissions are not needed, true (i guess copy / paste left over) - otherwise I don't know how to fix the problem of this PR.

Expand All @@ -9,10 +9,10 @@ permissions:
jobs:
labelWhenApproved:
if: ${{ github.repository_owner == 'armbian' }}
name: Label when approved
name: "Label when approved"
runs-on: ubuntu-latest
steps:
- name: Label when approved
- name: "Label when approved"
uses: pullreminders/label-when-approved-action@master
env:
APPROVALS: "1"
Expand Down